use ounit2 #161
Merged
use ounit2 #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alessandro-Barbieri
force-pushed
the
patch-1
branch
from
a3b57ec
to
72d9112
Compare
Signed-off-by: Alessandro-Barbieri <lssndrbarbieri@gmail.com>
|
Thanks |
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Sep 25, 2023
CHANGES: * **breaking change** Fix parsing & printing of IPv6 addresses in the host part of an uri If we follow the RFC3986 correctly, IPv6 must be surrounded by '[' and ']'. Old versions of `ocaml-uri` escaped these characters. The new version interprets these characters to recognize an IPv6 address. Users should take note of this change in behaviour, which fixes a number of bugs in HTTP requests. (@anmonteiro, review by several maintainers, mirage/ocaml-uri#169) * Upgrade tests to `ounit2` (@Alessandro-Barbieri, mirage/ocaml-uri#161)
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES: * **breaking change** Fix parsing & printing of IPv6 addresses in the host part of an uri If we follow the RFC3986 correctly, IPv6 must be surrounded by '[' and ']'. Old versions of `ocaml-uri` escaped these characters. The new version interprets these characters to recognize an IPv6 address. Users should take note of this change in behaviour, which fixes a number of bugs in HTTP requests. (@anmonteiro, review by several maintainers, mirage/ocaml-uri#169) * Upgrade tests to `ounit2` (@Alessandro-Barbieri, mirage/ocaml-uri#161)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.