-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add attempt to connect to socket before selecting it as runtime #78
Conversation
Signed-off-by: Evan Harris <echarris@smcm.edu>
if len(available) > 0 { | ||
return available[0] | ||
} | ||
|
||
return DockerRuntime | ||
return DockerRuntime // Question -> This runtime may not necessarily be available? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is a good idea to check if the default/assumed runtime (when no explicit runtime param is specified) is available. A wishlist enhancement :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A future TODO
@eharris128 there might be another bug to investigate there... The "auto crt" logic shouldn't have picked containerd unless containerd is the only thing is installed. What's the docker socket you have in your environment? What's the docker context info? |
Will share these details next time I am on my dev machine. |
@eharris128 can you also run |
Either way, the
|
@kcq very delayed here, but I ruined the reproducibility as I upgraded to Ubuntu 24 LTS last week (in order to work with Podman - as the Ubuntu 22 LTS's installation of Podman does not work for mint). With the Ubuntu 24 LTS default docker configuration, we no longer get the issue of defaulting to containerd (when docker is installed). |
@eharris128 no worries :) can you create a GitHub issue with the notes from our discussion about it |
What
Why
tui -> i
imagesOnCommand
invocation to usecontainerd
as runtime. However, the application could not talk to this containerd socket due to permission issues. The socket was there from the perspective ofStat
- but this did not guarantee sufficient access to communicate with the socket.How Tested
mint images
mint tui -> i
New Experience