From fcb21d812592b475b8d4e3f6cc066d84f11d91a9 Mon Sep 17 00:00:00 2001
From: Christian Sciberras <christian@sciberras.me>
Date: Sat, 1 Jul 2023 21:17:29 +0200
Subject: [PATCH] Ignore unannounced exceptions; declare return type

---
 tests/Form/GeneralTest.php | 44 ++++++++++++++++++++------------------
 1 file changed, 23 insertions(+), 21 deletions(-)

diff --git a/tests/Form/GeneralTest.php b/tests/Form/GeneralTest.php
index f552867..8fba022 100644
--- a/tests/Form/GeneralTest.php
+++ b/tests/Form/GeneralTest.php
@@ -1,16 +1,20 @@
 <?php
 
+/**
+ * @noinspection PhpDocMissingThrowsInspection
+ * @noinspection PhpUnhandledExceptionInspection
+ */
+
 namespace Behat\Mink\Tests\Driver\Form;
 
 use Behat\Mink\Exception\DriverException;
-use Behat\Mink\Exception\ElementNotFoundException;
 use Behat\Mink\Tests\Driver\TestCase;
 use Generator;
 
 final class GeneralTest extends TestCase
 {
     // test multiple submit buttons
-    public function testIssue212()
+    public function testIssue212(): void
     {
         $session = $this->getSession();
 
@@ -20,7 +24,7 @@ public function testIssue212()
         $this->assertEquals('poney', $field->getValue());
     }
 
-    public function testBasicForm()
+    public function testBasicForm(): void
     {
         $this->getSession()->visit($this->pathTo('/basic_form.html'));
 
@@ -60,7 +64,7 @@ public function testBasicForm()
     /**
      * @dataProvider formSubmitWaysDataProvider
      */
-    public function testFormSubmitWays(string $submitVia)
+    public function testFormSubmitWays(string $submitVia): void
     {
         $session = $this->getSession();
         $session->visit($this->pathTo('/basic_form.html'));
@@ -79,17 +83,17 @@ public function testFormSubmitWays(string $submitVia)
         }
     }
 
-    public static function formSubmitWaysDataProvider()
+    public static function formSubmitWaysDataProvider(): array
     {
-        return array(
-            array('Save'),
-            array('input-type-image'),
-            array('button-without-type'),
-            array('button-type-submit'),
-        );
+        return [
+            ['Save'],
+            ['input-type-image'],
+            ['button-without-type'],
+            ['button-type-submit'],
+        ];
     }
 
-    public function testFormSubmit()
+    public function testFormSubmit(): void
     {
         $session = $this->getSession();
         $session->visit($this->pathTo('/basic_form.html'));
@@ -104,7 +108,7 @@ public function testFormSubmit()
         }
     }
 
-    public function testFormSubmitWithoutButton()
+    public function testFormSubmitWithoutButton(): void
     {
         $session = $this->getSession();
         $session->visit($this->pathTo('/form_without_button.html'));
@@ -119,7 +123,7 @@ public function testFormSubmitWithoutButton()
         }
     }
 
-    public function testBasicGetForm()
+    public function testBasicGetForm(): void
     {
         $this->getSession()->visit($this->pathTo('/basic_get_form.php'));
         $webAssert = $this->getAssertSession();
@@ -135,7 +139,7 @@ public function testBasicGetForm()
         $this->assertEquals('some#query', $div->getText());
     }
 
-    public function testAdvancedForm()
+    public function testAdvancedForm(): void
     {
         $this->getSession()->visit($this->pathTo('/advanced_form.html'));
         $page = $this->getSession()->getPage();
@@ -224,7 +228,7 @@ public function testAdvancedForm()
         }
     }
 
-    public function testQuoteInValue()
+    public function testQuoteInValue(): void
     {
         $this->getSession()->visit($this->pathTo('/advanced_form.html'));
 
@@ -264,7 +268,7 @@ public function testQuoteInValue()
         }
     }
 
-    public function testMultiInput()
+    public function testMultiInput(): void
     {
         $this->getSession()->visit($this->pathTo('/multi_input_form.html'));
         $page = $this->getSession()->getPage();
@@ -309,7 +313,7 @@ public function testMultiInput()
         $this->assertStringContainsString($out, $page->getContent());
     }
 
-    public function testAdvancedFormSecondSubmit()
+    public function testAdvancedFormSecondSubmit(): void
     {
         $this->getSession()->visit($this->pathTo('/advanced_form.html'));
         $page = $this->getSession()->getPage();
@@ -331,7 +335,7 @@ public function testAdvancedFormSecondSubmit()
         }
     }
 
-    public function testSubmitEmptyTextarea()
+    public function testSubmitEmptyTextarea(): void
     {
         $this->getSession()->visit($this->pathTo('/empty_textarea.html'));
         $page = $this->getSession()->getPage();
@@ -353,9 +357,7 @@ public function testSubmitEmptyTextarea()
 
     /**
      * @dataProvider provideInvalidValues
-     *
      * @param mixed $value
-     * @throws ElementNotFoundException
      */
     public function testSetInvalidValueInField(string $field, $value): void
     {