Move Batch job structs from minio/cmd #135
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSushmitha8
requested review from
poornas,
harshavardhana,
kannappanr and
jiuker
harshavardhana
requested changes
Oct 15, 2024
| ) | ||
|
|
||
| // BatchJobRequest to start batch job | ||
| type BatchJobRequest struct { |
There was a problem hiding this comment.
there is no reason to move this to a sub-folder? what is the reason?
There was a problem hiding this comment.
oh I see this is needed for external usage? the best place for this is in madmin-go not in this project @SSushmitha8
There was a problem hiding this comment.
I want both minio (remove existing structs in minio) and aistor to point to these same structs @harshavardhana , if we have these in madmin-go then there would be circular dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move Batch job structs from minio/cmd to pkg, to use them in aistor yaml marshaling