Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move UI from console repository to this repository #1469

Merged
merged 17 commits into from
Mar 2, 2023

Conversation

dvaldivia
Copy link
Collaborator

@dvaldivia dvaldivia commented Feb 28, 2023

Moving towards single container releases for v5

@cniackz
Copy link
Contributor

cniackz commented Feb 28, 2023

My focus here is to look at the test, to fix them accordingly for this PR.

My first task is: I will fix ./web-app/check-warnings.sh to fix this problem

./web-app/check-warnings.sh:16:8: note: Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead. [SC2002]

@cniackz
Copy link
Contributor

cniackz commented Feb 28, 2023

First change is going to be:

Cesars-MacBook-Pro:operator cniackz$ gst
On branch operator-ui
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   web-app/check-warnings.sh

no changes added to commit (use "git add" and/or "git commit -a")
Cesars-MacBook-Pro:operator cniackz$ git diff .
diff --git a/web-app/check-warnings.sh b/web-app/check-warnings.sh
index 2c6e7121..9013400d 100755
--- a/web-app/check-warnings.sh
+++ b/web-app/check-warnings.sh
@@ -13,7 +13,7 @@ try() { "$@" &> yarn.log || die "cannot $*"; }
 rm -f yarn.log
 try make build-static
 
-if cat yarn.log | grep "Compiled with warnings"; then
+if grep "Compiled with warnings" yarn.log; then
   echo "There are warnings in the code"
   exit 1
 fi
Cesars-MacBook-Pro:operator cniackz$ 

@cniackz
Copy link
Contributor

cniackz commented Mar 1, 2023

@dvaldivia when you get a chance, please take a look at this PRs:

  1. Fix Shellcheck Test dvaldivia/operator#7

As I will keep adding more to fix the tests.

dvaldivia and others added 2 commits March 1, 2023 16:00
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
dvaldivia and others added 5 commits March 1, 2023 17:04
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
@cniackz
Copy link
Contributor

cniackz commented Mar 2, 2023

@dvaldivia please take a look at:

dvaldivia#9

It will fix coverage test as below:

https://github.com/minio/operator/actions/runs/4314052180

image

@cniackz
Copy link
Contributor

cniackz commented Mar 2, 2023

@dvaldivia also take a look at dvaldivia#10

To fix:

Installing lite tenant
error: evalsymlink failure on '/home/runner/work/operator/operator/web-app/tests/scripts/tenant-lite' : lstat /home/runner/work/operator/operator/web-app/tests/scripts/tenant-lite: no such file or directory

Fixing coverage test by updating go version
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Copy link
Contributor

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Steps to init server:

  1. Start Operator server go run . ui
  2. Install Yarn packages in web-app
  3. Run yarn start in web-app folder

@dvaldivia dvaldivia merged commit f6c9c8b into minio:master Mar 2, 2023
@dvaldivia dvaldivia deleted the operator-ui branch March 2, 2023 22:45
@cniackz cniackz mentioned this pull request Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants