Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loadBalancerIP and externalTrafficPolicy values for exposeServices #1357

Open
RomanKrasavtsev opened this issue Nov 28, 2022 · 1 comment
Assignees
Labels
community enhancement New feature or request

Comments

@RomanKrasavtsev
Copy link
Contributor

RomanKrasavtsev commented Nov 28, 2022

Currently there is no option to specify loadBalancerIP and externalTrafficPolicy values for exposeServices
https://github.com/minio/operator/blob/master/helm/tenant/values.yaml#L110

Some cloud providers allow you to specify the loadBalancerIP. In those cases, the load-balancer is created with the user-specified loadBalancerIP.
https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer

You can set the spec.externalTrafficPolicy field to control how traffic from external sources is routed. Valid values are Cluster and Local. Set the field to Cluster to route external traffic to all ready endpoints and Local to only route to ready node-local endpoints. If the traffic policy is Local and there are no node-local endpoints, the kube-proxy does not forward any traffic for the relevant Service.
https://kubernetes.io/docs/concepts/services-networking/service/#external-traffic-policy

Describe the solution you'd like

exposeServices:
  console: false
  minio: true
    externalTrafficPolicy: Local
    loadBalancerIP: 192.168.1.10
@dvaldivia
Copy link
Collaborator

the challenge here is that we would need to migrate people from the boolean value to an object value, so I think something along the lines of the following might be the way.

exposeServices:
  console: false
  minio: true
  minioMeta:
    externalTrafficPolicy: Local
    loadBalancerIP: 192.168.1.10

@cesnietor cesnietor added enhancement New feature or request and removed triage labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants