Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing affinity and tolerations customization for log, db, prometheus in helm template for tenant #1261

Closed
vldorl opened this issue Aug 29, 2022 · 4 comments · Fixed by #1272
Assignees
Labels
bug Something isn't working community triage

Comments

@vldorl
Copy link

vldorl commented Aug 29, 2022

Hello!
I have nodes: worker-1, worker-2, worker-3, worker-N
Nodes worker-{1..3} are tainted and labeled for selecting.
I deploy tenant to nodes worker-{1..3} using affinity rules and tolerations with helm chart.

Expected Behavior

All pool pods and service pods (log, log:db, prometheus) running on nodes worker-{1..3}.

Current Behavior

Pool pods are assigned to nodes as expected.
Pods log, log:db, prometheus are assigned randomly, affinity rules and tolerations are ignored due to absent customized section in tenant template.

Possible Solution

To fix template (e.g. https://github.com/minio/operator/blob/master/helm/tenant/templates/tenant.yaml#L249) adding customization for affinity and tolerations.

Steps to Reproduce (for bugs)

  1. Deploy operator using helm chart
  2. Set affinity and tolerations for pool, log, log:db and prometheus in values.yaml for tenant chart
  3. Deploy tenant
  4. See running pool pods on nodes worker{1..3} and rest on random nodes

Context

I have 2 node tiers: stateful and stateless. Minio pool pods and rest have to be deployed on stateful, which have storage.

Your Environment

  • Version used: 4.4.28
  • Environment name and version: k8s v1.23.7
  • Server type and version: Virtual Machine
  • Operating System and version: Linux worker-1 5.4.17-2136.307.3.1.el8uek.x86_64 #2 SMP Mon May 9 17:29:47 PDT 2022 x86_64 x86_64 x86_64 GNU/Linux
@harshavardhana
Copy link
Member

Feel free to send a PR @vldorl

@dnskr
Copy link
Contributor

dnskr commented Aug 30, 2022

@vldorl Hi! There is similar PR #674
Do you want to create a PR?

@vldorl
Copy link
Author

vldorl commented Aug 30, 2022

Hello, @dnskr!
Already #1265

@pjuarezd
Copy link
Member

Thank you for the PR @vldorl, It seems that as is will not work, please merge this PR into your branch with some bugfixes

vldorl#1

@pjuarezd pjuarezd self-assigned this Sep 1, 2022
@pjuarezd pjuarezd added the bug Something isn't working label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community triage
Projects
None yet
4 participants