Remove more unused APIs #3537
Merged
Remove more unused APIs #3537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes several unused APIs and related code including login endpoints, OAuth2 authentication support, LDAP authentication logic, and associated swagger specification files. Key changes include:
- Removal of external IDP login endpoints and associated helper functions in user_login.go and auth endpoints.
- Elimination of bucket tags API endpoints and corresponding swagger definitions.
- Purge of LDAP authentication code and unused configuration/test functions.
Reviewed Changes
Copilot reviewed 42 out of 42 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| api/user_login.go | Removed unused OAuth2 login handler and simplified getLoginDetailsResponse. |
| api/user_buckets.go | Removed bucket tags handler logic. |
| api/operations/* | Deleted multiple swagger-generated files for unused endpoints. |
| api/client.go | Removed LDAP authentication branch from console credentials creation. |
| api/embedded_spec.go | Removed swagger definitions for removed endpoints. |
| api/consts.go, config.go, tests | Cleaned configuration and test references to removed APIs. |
bexsoft
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.