Fix lint errors correctly

Author: Jillian Inapurapu

restapi/user_buckets_lifecycle.go

@@ -197,13 +197,12 @@ func addBucketLifecycle(ctx context.Context, client MinioClient, params bucketAp
 			noncurrentVersionTransitionStorageClass := strings.ToUpper(params.Body.NoncurrentversionTransitionStorageClass)
 			opts.NoncurrentVersionTransitionDays = &newerNoncurrentVersionTransitionVersions
 			opts.NoncurrentVersionTransitionStorageClass = &noncurrentVersionTransitionStorageClass
-		}
-		if params.Body.NoncurrentversionTransitionDays > 0 {
+		} else if params.Body.NoncurrentversionTransitionDays > 0 {
 			noncurrentVersionTransitionDays := int(params.Body.NoncurrentversionTransitionDays)
 			noncurrentVersionTransitionStorageClass := strings.ToUpper(params.Body.NoncurrentversionTransitionStorageClass)
 			opts.NoncurrentVersionTransitionDays = &noncurrentVersionTransitionDays
 			opts.NoncurrentVersionTransitionStorageClass = &noncurrentVersionTransitionStorageClass
-		} else {
+		} else if params.Body.TransitionDays > 0 {
 			tdays := strconv.Itoa(int(params.Body.TransitionDays))
 			sclass := strings.ToUpper(params.Body.StorageClass)
 			opts.TransitionDays = &tdays
@@ -231,11 +230,10 @@ func addBucketLifecycle(ctx context.Context, client MinioClient, params bucketAp
 		if params.Body.NewerNoncurrentversionExpirationVersions > 0 {
 			versions := int(params.Body.NewerNoncurrentversionExpirationVersions)
 			opts.NewerNoncurrentExpirationVersions = &versions
-		}
-		if params.Body.NoncurrentversionExpirationDays > 0 {
+		} else if params.Body.NoncurrentversionExpirationDays > 0 {
 			days := int(params.Body.NoncurrentversionExpirationDays)
 			opts.NoncurrentVersionExpirationDays = &days
-		} else {
+		} else if params.Body.ExpiryDays > 0 {
 			days := strconv.Itoa(int(params.Body.ExpiryDays))
 			opts.ExpiryDays = &days
 		}
@@ -305,20 +303,20 @@ func editBucketLifecycle(ctx context.Context, client MinioClient, params bucketA
 			Tags:                      &params.Body.Tags,
 			ExpiredObjectDeleteMarker: &params.Body.ExpiredObjectDeleteMarker,
 		}
-		if params.Body.NewerNoncurrentversionTransitionVersions > 0 {
-			newerNoncurrentVersionTransitionVersions := int(params.Body.NewerNoncurrentversionTransitionVersions)
-			noncurrentVersionTransitionStorageClass := strings.ToUpper(params.Body.NoncurrentversionTransitionStorageClass)
-			opts.NewerNoncurrentExpirationVersions = &newerNoncurrentVersionTransitionVersions
-			opts.NoncurrentVersionTransitionStorageClass = &noncurrentVersionTransitionStorageClass
 
-		}
 		if params.Body.NoncurrentversionTransitionDays > 0 {
 			noncurrentVersionTransitionDays := int(params.Body.NoncurrentversionTransitionDays)
 			noncurrentVersionTransitionStorageClass := strings.ToUpper(params.Body.NoncurrentversionTransitionStorageClass)
 			opts.NoncurrentVersionTransitionDays = &noncurrentVersionTransitionDays
 			opts.NoncurrentVersionTransitionStorageClass = &noncurrentVersionTransitionStorageClass
 
-		} else {
+		} else if params.Body.NewerNoncurrentversionTransitionVersions > 0 {
+			newerNoncurrentVersionTransitionVersions := int(params.Body.NewerNoncurrentversionTransitionVersions)
+			noncurrentVersionTransitionStorageClass := strings.ToUpper(params.Body.NoncurrentversionTransitionStorageClass)
+			opts.NewerNoncurrentExpirationVersions = &newerNoncurrentVersionTransitionVersions
+			opts.NoncurrentVersionTransitionStorageClass = &noncurrentVersionTransitionStorageClass
+
+		} else if params.Body.TransitionDays > 0 {
 			tdays := strconv.Itoa(int(params.Body.TransitionDays))
 			sclass := strings.ToUpper(params.Body.StorageClass)
 			opts.TransitionDays = &tdays
@@ -341,14 +339,14 @@ func editBucketLifecycle(ctx context.Context, client MinioClient, params bucketA
 			Tags:                      &params.Body.Tags,
 			ExpiredObjectDeleteMarker: &params.Body.ExpiredObjectDeleteMarker,
 		}
-		if params.Body.NewerNoncurrentversionExpirationVersions > 0 {
-			versions := int(params.Body.NewerNoncurrentversionExpirationVersions)
-			opts.NewerNoncurrentExpirationVersions = &versions
-		}
+
 		if params.Body.NoncurrentversionExpirationDays > 0 {
 			days := int(params.Body.NoncurrentversionExpirationDays)
 			opts.NoncurrentVersionExpirationDays = &days
-		} else {
+		} else if params.Body.NewerNoncurrentversionExpirationVersions > 0 {
+			versions := int(params.Body.NewerNoncurrentversionExpirationVersions)
+			opts.NewerNoncurrentExpirationVersions = &versions
+		} else if params.Body.ExpiryDays > 0 {
 			days := strconv.Itoa(int(params.Body.ExpiryDays))
 			opts.ExpiryDays = &days
 		}