Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: canonical request path if empty choose '/' #1165

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

harshavardhana
Copy link
Member

additionally this PR allows content-type and
content-length to be part of signed headers as
this is allowed in signature v4.

SignatureV4 has no empty paths as part of canonical
request, at the minimum it must be `/`.

additionally this PR allows content-type and
content-length to be part of signed headers as
this is allowed in signature v4.
Copy link

@ravindk89 ravindk89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursory glance looks fine.

Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit ff6af3e into minio:master Nov 24, 2021
@harshavardhana harshavardhana deleted the fix-canonical branch November 24, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants