Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove use fPutObject impl, use putObject internally #1159

Merged
merged 1 commit into from
Jun 2, 2023
Merged

refactor: remove use fPutObject impl, use putObject internally #1159

merged 1 commit into from
Jun 2, 2023

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented May 24, 2023 •
edited
Loading

There is no need to implement fPutObject and ObjectUploader twice, just read size and call putObject internally

@trim21 trim21 marked this pull request as ready for review May 24, 2023 19:20
aldy505
aldy505 reviewed May 26, 2023
View reviewed changes
Copy link
Contributor

@aldy505 aldy505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aldy505 aldy505 mentioned this pull request May 26, 2023
Merged
prakashsvmx
prakashsvmx approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified

  • Upload
  • Multipart upload
  • Content type ( checked with mc as well)

LGTM 👍

@trim21
Copy link
Contributor Author

trim21 commented Jun 2, 2023

/ping

@prakashsvmx prakashsvmx merged commit 8bd5ab9 into minio:master Jun 2, 2023
@trim21 trim21 deleted the clean-code branch June 2, 2023 04:22
@VaniHaripriya VaniHaripriya mentioned this pull request Jun 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldy505 aldy505 aldy505 left review comments

@prakashsvmx prakashsvmx prakashsvmx approved these changes

@kaankabalak kaankabalak kaankabalak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trim21 @aldy505 @prakashsvmx @kaankabalak