Skip to content

Conversation

@martijn00
Copy link
Contributor

Updated version of #795

@ebozduman can you run this?

@martijn00 martijn00 force-pushed the feat-replace-dynamic-with-class branch from a4b39c3 to b085d63 Compare August 3, 2023 15:22
ebozduman
ebozduman previously approved these changes Aug 4, 2023
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martijn00 martijn00 force-pushed the feat-replace-dynamic-with-class branch from e86a879 to 074a0f4 Compare August 4, 2023 08:32
@martijn00
Copy link
Contributor Author

martijn00 commented Aug 4, 2023

@ebozduman Ive done a rebase to fix the conflict. Can you run again?

@martijn00
Copy link
Contributor Author

@ebozduman now it should be correct. Can you run again?

Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants