Warnings again (#796)

* Fix more warnings

* Nuget update

* Extend interface

* Move progres

* Namespace changes

* Format

* Renames

* Moves

* More moves

* More warnings

* Use new package for reactive

* Add editor config

* Allow 0

* Fix warnings

* Warnings as error

* Lint changes

* Revert "Drawingback Lint changes"

This reverts commit ed1ba1b.

* Fix lines

* Add editor config update

* More editor

* More editorconfig

* Format

* Format

* Format

* Fixes

* Format

* Format

* Runs bucket notification test by itself

---------

Co-authored-by: Ersan Bozduman <ersanbozduman@gmail.com>

Author: martijn00

.editorconfig

@@ -0,0 +1,149 @@
+# EditorConfig is awesome:http://EditorConfig.org
+
+# top-most EditorConfig file
+root = true
+
+[*.{cs,vb}]
+#### Naming styles ####
+
+# Unix-style newlines with a newline ending every file
+[*]
+end_of_line = lf
+insert_final_newline = true
+
+# Naming rules
+
+dotnet_naming_rule.interface_should_be_begins_with_i.severity = suggestion
+dotnet_naming_rule.interface_should_be_begins_with_i.symbols = interface
+dotnet_naming_rule.interface_should_be_begins_with_i.style = begins_with_i
+
+dotnet_naming_rule.types_should_be_pascal_case.severity = suggestion
+dotnet_naming_rule.types_should_be_pascal_case.symbols = types
+dotnet_naming_rule.types_should_be_pascal_case.style = pascal_case
+
+dotnet_naming_rule.non_field_members_should_be_pascal_case.severity = suggestion
+dotnet_naming_rule.non_field_members_should_be_pascal_case.symbols = non_field_members
+dotnet_naming_rule.non_field_members_should_be_pascal_case.style = pascal_case
+
+# Symbol specifications
+
+dotnet_naming_symbols.interface.applicable_kinds = interface
+dotnet_naming_symbols.interface.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
+dotnet_naming_symbols.interface.required_modifiers = 
+
+dotnet_naming_symbols.types.applicable_kinds = class, struct, interface, enum
+dotnet_naming_symbols.types.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
+dotnet_naming_symbols.types.required_modifiers = 
+
+dotnet_naming_symbols.non_field_members.applicable_kinds = property, event, method
+dotnet_naming_symbols.non_field_members.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
+dotnet_naming_symbols.non_field_members.required_modifiers = 
+
+# Naming styles
+
+dotnet_naming_style.begins_with_i.required_prefix = I
+dotnet_naming_style.begins_with_i.required_suffix = 
+dotnet_naming_style.begins_with_i.word_separator = 
+dotnet_naming_style.begins_with_i.capitalization = pascal_case
+
+dotnet_naming_style.pascal_case.required_prefix = 
+dotnet_naming_style.pascal_case.required_suffix = 
+dotnet_naming_style.pascal_case.word_separator = 
+dotnet_naming_style.pascal_case.capitalization = pascal_case
+
+dotnet_naming_style.pascal_case.required_prefix = 
+dotnet_naming_style.pascal_case.required_suffix = 
+dotnet_naming_style.pascal_case.word_separator = 
+dotnet_naming_style.pascal_case.capitalization = pascal_case
+dotnet_style_coalesce_expression = true:suggestion
+dotnet_style_null_propagation = true:suggestion
+dotnet_style_prefer_is_null_check_over_reference_equality_method = true:suggestion
+dotnet_style_prefer_auto_properties = true:silent
+dotnet_style_operator_placement_when_wrapping = beginning_of_line
+tab_width = 4
+indent_size = 4
+end_of_line = crlf
+dotnet_style_object_initializer = true:suggestion
+dotnet_style_collection_initializer = true:suggestion
+dotnet_style_prefer_simplified_boolean_expressions = true:suggestion
+dotnet_style_prefer_conditional_expression_over_assignment = true:silent
+dotnet_style_prefer_conditional_expression_over_return = true:silent
+dotnet_style_explicit_tuple_names = true:suggestion
+dotnet_style_prefer_inferred_tuple_names = true:suggestion
+dotnet_style_prefer_inferred_anonymous_type_member_names = true:suggestion
+dotnet_style_prefer_compound_assignment = true:suggestion
+dotnet_style_prefer_simplified_interpolation = true:suggestion
+dotnet_style_namespace_match_folder = true:suggestion
+dotnet_style_readonly_field = true:suggestion
+dotnet_style_predefined_type_for_locals_parameters_members = true:silent
+dotnet_style_predefined_type_for_member_access = true:silent
+dotnet_style_require_accessibility_modifiers = for_non_interface_members:silent
+dotnet_style_allow_multiple_blank_lines_experimental = false:warning
+dotnet_style_allow_statement_immediately_after_block_experimental = true:silent
+dotnet_code_quality_unused_parameters = all:suggestion
+dotnet_style_parentheses_in_arithmetic_binary_operators = always_for_clarity:silent
+dotnet_style_parentheses_in_other_binary_operators = always_for_clarity:silent
+dotnet_style_parentheses_in_relational_binary_operators = always_for_clarity:silent
+dotnet_style_parentheses_in_other_operators = never_if_unnecessary:silent
+dotnet_style_qualification_for_field = false:silent
+dotnet_style_qualification_for_property = false:silent
+dotnet_style_qualification_for_method = false:silent
+dotnet_style_qualification_for_event = false:silent
+
+[*.cs]
+MA0051.maximum_lines_per_method = 100
+MA0051.maximum_statements_per_method = 60
+MA0051.skip_local_functions = false # skip local functions when counting statements
+csharp_using_directive_placement = outside_namespace:suggestion
+csharp_prefer_simple_using_statement = true:suggestion
+csharp_prefer_braces = when_multiline:suggestion
+csharp_style_namespace_declarations = file_scoped:warning
+csharp_style_prefer_method_group_conversion = true:silent
+csharp_style_prefer_top_level_statements = true:warning
+csharp_style_prefer_primary_constructors = true:suggestion
+csharp_style_expression_bodied_methods = false:silent
+csharp_style_expression_bodied_constructors = false:silent
+csharp_style_expression_bodied_operators = false:silent
+csharp_style_expression_bodied_properties = true:suggestion
+csharp_style_expression_bodied_indexers = true:suggestion
+csharp_style_expression_bodied_accessors = true:suggestion
+csharp_style_expression_bodied_lambdas = true:suggestion
+csharp_style_expression_bodied_local_functions = false:silent
+csharp_indent_labels = one_less_than_current
+csharp_space_around_binary_operators = before_and_after
+csharp_style_throw_expression = true:suggestion
+csharp_style_prefer_null_check_over_type_check = true:suggestion
+csharp_prefer_simple_default_expression = true:suggestion
+csharp_style_prefer_local_over_anonymous_function = true:suggestion
+csharp_style_prefer_index_operator = true:suggestion
+csharp_style_prefer_range_operator = true:suggestion
+csharp_style_implicit_object_creation_when_type_is_apparent = true:suggestion
+csharp_style_prefer_tuple_swap = true:suggestion
+csharp_style_prefer_utf8_string_literals = true:suggestion
+csharp_style_inlined_variable_declaration = true:suggestion
+csharp_style_deconstructed_variable_declaration = true:suggestion
+csharp_style_unused_value_assignment_preference = discard_variable:suggestion
+csharp_style_unused_value_expression_statement_preference = discard_variable:silent
+csharp_prefer_static_local_function = true:suggestion
+csharp_style_prefer_readonly_struct = true:suggestion
+csharp_style_prefer_readonly_struct_member = true:suggestion
+csharp_style_allow_embedded_statements_on_same_line_experimental = true:silent
+csharp_style_allow_blank_lines_between_consecutive_braces_experimental = false:silent
+csharp_style_allow_blank_line_after_colon_in_constructor_initializer_experimental = true:silent
+csharp_style_allow_blank_line_after_token_in_conditional_expression_experimental = true:silent
+csharp_style_allow_blank_line_after_token_in_arrow_expression_clause_experimental = true:silent
+csharp_style_conditional_delegate_call = true:suggestion
+csharp_style_prefer_switch_expression = true:suggestion
+csharp_style_prefer_pattern_matching = true:silent
+csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion
+csharp_style_pattern_matching_over_as_with_null_check = true:suggestion
+csharp_style_prefer_not_pattern = true:suggestion
+csharp_style_prefer_extended_property_pattern = true:suggestion
+csharp_style_var_for_built_in_types = true:suggestion
+csharp_style_var_when_type_is_apparent = true:suggestion
+csharp_style_var_elsewhere = true:suggestion
+csharp_preserve_single_line_blocks = true
+csharp_preserve_single_line_statements = true
+csharp_indent_braces = false
+csharp_new_line_before_members_in_object_initializers = false
+csharp_new_line_before_open_brace = all

.gitattributes

@@ -1,7 +1,7 @@
 ###############################################################################
 # Set default behavior to automatically normalize line endings.
 ###############################################################################
-* text=lf
+* text=auto eol=lf
 
 # Check out the following as ln always for osx/linux/cygwin
 *.sh text eol=lf

Directory.Build.props

@@ -24,9 +24,10 @@
         <NoWarn>$(NoWarn);CS1591</NoWarn>
         <Platform>AnyCPU</Platform>
 
-        <EnableNETAnalyzers>false</EnableNETAnalyzers>
+        <EnableNETAnalyzers>true</EnableNETAnalyzers>
         <AnalysisLevel>latest</AnalysisLevel>
-        <AnalysisMode>All</AnalysisMode>
+        <AnalysisMode>Default</AnalysisMode>
+        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
 
         <IsTestProject>$(MSBuildProjectName.Contains('Test'))</IsTestProject>
     </PropertyGroup>
@@ -78,11 +79,11 @@
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>
-        <PackageReference Include="Meziantou.Analyzer" Version="2.0.60">
+        <PackageReference Include="Meziantou.Analyzer" Version="2.0.61">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
         </PackageReference>
         -->
     </ItemGroup>
 
-</Project>
+</Project>

FileUploader/FileUpload.cs

@@ -17,6 +17,7 @@
 using System.Net;
 using System.Runtime.InteropServices;
 using Minio;
+using Minio.DataModel.Args;
 
 namespace FileUploader;
 
@@ -107,4 +108,4 @@ private static async Task Run(IMinioClient minio)
         // run in, dissappears as soon as the test code completes.
         if (IsWindows()) Console.ReadLine();
     }
-}
+}

Minio.Examples/Cases/AWSEnvironmentProviderExample.cs

@@ -16,6 +16,7 @@
  */
 
 using Minio.Credentials;
+using Minio.DataModel.Args;
 using Minio.Exceptions;
 
 namespace Minio.Examples.Cases;
@@ -48,4 +49,4 @@ public static async Task Run()
             Console.WriteLine($"[Bucket] IAMAWSProviderExample example case encountered Exception: {e}");
         }
     }
-}
+}

Minio.Examples/Cases/AssumeRoleProviderExample.cs

@@ -16,6 +16,7 @@
 //
 
 using Minio.Credentials;
+using Minio.DataModel.Args;
 
 namespace Minio.Examples.Cases;
 
@@ -63,4 +64,4 @@ public static async Task Run()
             Console.WriteLine($"AssumeRoleProvider test exception: {e}\n");
         }
     }
-}
+}

Minio.Examples/Cases/BucketExists.cs

@@ -14,6 +14,8 @@
  * limitations under the License.
  */
 
+using Minio.DataModel.Args;
+
 namespace Minio.Examples.Cases;
 
 internal static class BucketExists
@@ -36,4 +38,4 @@ public static async Task Run(IMinioClient minio,
             Console.WriteLine($"[Bucket]  Exception: {e}");
         }
     }
-}
+}

Minio.Examples/Cases/CertificateIdentityProviderExample.cs

@@ -17,6 +17,7 @@
 
 using System.Security.Cryptography.X509Certificates;
 using Minio.Credentials;
+using Minio.DataModel.Args;
 
 namespace Minio.Examples.Cases;
 
@@ -56,4 +57,4 @@ public static async Task Run()
             Console.WriteLine($"\nCertificateIdentityProvider test exception: {e}\n");
         }
     }
-}
+}

Minio.Examples/Cases/ChainedCredentialProvider.cs

@@ -16,6 +16,7 @@
  */
 
 using Minio.Credentials;
+using Minio.DataModel.Args;
 using Minio.Exceptions;
 
 namespace Minio.Examples.Cases;
@@ -49,4 +50,4 @@ public static async Task Run()
             Console.WriteLine($"[Bucket] ChainedCredentialProvider example case encountered Exception: {e}");
         }
     }
-}
+}

Minio.Examples/Cases/ClearObjectRetention.cs

@@ -14,6 +14,8 @@
  * limitations under the License.
  */
 
+using Minio.DataModel.Args;
+
 namespace Minio.Examples.Cases;
 
 public static class ClearObjectRetention
@@ -45,4 +47,4 @@ await minio.ClearObjectRetentionAsync(
             Console.WriteLine($"[Object]  Exception: {e}");
         }
     }
-}
+}