Feat replace dynamic with class (#823)

* perf:Replace dynamic with class for better performance
Fix:NativeAOT build issue

* Format

* Format

---------

Co-authored-by: mytelegram <mytelegramserver@outlook.com>

Author: martijn00

Minio.Tests/UtilsTest.cs

@@ -159,10 +159,10 @@ public void TestInvalidCOPYPartSize()
     public void TestValidPartSize1()
     {
         // { partSize = 550502400, partCount = 9987, lastPartSize = 241172480 }
-        dynamic partSizeObject = Utils.CalculateMultiPartSize(5497558138880);
-        double partSize = partSizeObject.partSize;
-        double partCount = partSizeObject.partCount;
-        double lastPartSize = partSizeObject.lastPartSize;
+        var partSizeObject = Utils.CalculateMultiPartSize(5497558138880);
+        var partSize = partSizeObject.PartSize;
+        var partCount = partSizeObject.PartCount;
+        var lastPartSize = partSizeObject.LastPartSize;
         Assert.AreEqual(partSize, 553648128);
         Assert.AreEqual(partCount, 9930);
         Assert.AreEqual(lastPartSize, 385875968);
@@ -171,10 +171,10 @@ public void TestValidPartSize1()
     [TestMethod]
     public void TestValidPartSize2()
     {
-        dynamic partSizeObject = Utils.CalculateMultiPartSize(500000000000, true);
-        double partSize = partSizeObject.partSize;
-        double partCount = partSizeObject.partCount;
-        double lastPartSize = partSizeObject.lastPartSize;
+        var partSizeObject = Utils.CalculateMultiPartSize(500000000000, true);
+        var partSize = partSizeObject.PartSize;
+        var partCount = partSizeObject.PartCount;
+        var lastPartSize = partSizeObject.LastPartSize;
         Assert.AreEqual(partSize, 536870912);
         Assert.AreEqual(partCount, 932);
         Assert.AreEqual(lastPartSize, 173180928);

Minio/ApiEndpoints/ObjectOperations.cs

@@ -874,10 +874,10 @@ private async Task<IDictionary<int, string>> PutObjectPartAsync(PutObjectPartArg
         CancellationToken cancellationToken = default)
     {
         args?.Validate();
-        dynamic multiPartInfo = Utils.CalculateMultiPartSize(args.ObjectSize);
-        double partSize = multiPartInfo.partSize;
-        double partCount = multiPartInfo.partCount;
-        double lastPartSize = multiPartInfo.lastPartSize;
+        var multiPartInfo = Utils.CalculateMultiPartSize(args.ObjectSize);
+        var partSize = multiPartInfo.PartSize;
+        var partCount = multiPartInfo.PartCount;
+        var lastPartSize = multiPartInfo.LastPartSize;
         var totalParts = new Part[(int)partCount];
 
         var expectedReadSize = partSize;
@@ -947,10 +947,10 @@ private async Task<IDictionary<int, string>> PutObjectPartAsync(PutObjectPartArg
     private async Task MultipartCopyUploadAsync(MultipartCopyUploadArgs args,
         CancellationToken cancellationToken = default)
     {
-        dynamic multiPartInfo = Utils.CalculateMultiPartSize(args.CopySize, true);
-        double partSize = multiPartInfo.partSize;
-        double partCount = multiPartInfo.partCount;
-        double lastPartSize = multiPartInfo.lastPartSize;
+        var multiPartInfo = Utils.CalculateMultiPartSize(args.CopySize, true);
+        var partSize = multiPartInfo.PartSize;
+        var partCount = multiPartInfo.PartCount;
+        var lastPartSize = multiPartInfo.LastPartSize;
         var totalParts = new Part[(int)partCount];
 
         var nmuArgs = new NewMultipartUploadCopyArgs()
@@ -1358,10 +1358,10 @@ private async Task MultipartCopyUploadAsync(string bucketName, string objectName
     {
         // For all sizes greater than 5GB or if Copy byte range specified in conditions and byte range larger
         // than minimum part size (5 MB) do multipart.
-        dynamic multiPartInfo = Utils.CalculateMultiPartSize(copySize, true);
-        double partSize = multiPartInfo.partSize;
-        double partCount = multiPartInfo.partCount;
-        double lastPartSize = multiPartInfo.lastPartSize;
+        var multiPartInfo = Utils.CalculateMultiPartSize(copySize, true);
+        var partSize = multiPartInfo.PartSize;
+        var partCount = multiPartInfo.PartCount;
+        var lastPartSize = multiPartInfo.LastPartSize;
         var totalParts = new Part[(int)partCount];
 
         var sseHeaders = new Dictionary<string, string>(StringComparer.Ordinal);

Minio/DataModel/MultiPartInfo.cs

@@ -0,0 +1,8 @@
+namespace Minio.DataModel;
+
+public class MultiPartInfo
+{
+    public double PartSize { get; set; }
+    public double PartCount { get; set; }
+    public double LastPartSize { get; set; }
+}

Minio/Helper/Utils.cs

@@ -16,7 +16,6 @@
 
 using System.ComponentModel;
 using System.Diagnostics.CodeAnalysis;
-using System.Dynamic;
 using System.Globalization;
 using System.Reflection;
 using System.Security.Cryptography;
@@ -26,6 +25,7 @@
 using System.Xml;
 using System.Xml.Linq;
 using System.Xml.Serialization;
+using Minio.DataModel;
 using Minio.Exceptions;
 #if !NET6_0_OR_GREATER
 using System.Collections.Concurrent;
@@ -265,7 +265,7 @@ public static bool CaseInsensitiveContains(string text, string value,
     /// <param name="size"></param>
     /// <param name="copy"> If true, use COPY part size, else use PUT part size</param>
     /// <returns></returns>
-    public static object CalculateMultiPartSize(long size, bool copy = false)
+    public static MultiPartInfo CalculateMultiPartSize(long size, bool copy = false)
     {
         if (size == -1) size = Constants.MaximumStreamObjectSize;
 
@@ -278,11 +278,8 @@ public static object CalculateMultiPartSize(long size, bool copy = false)
         partSize = (double)Math.Ceiling((decimal)partSize / minPartSize) * minPartSize;
         var partCount = Math.Ceiling(size / partSize);
         var lastPartSize = size - ((partCount - 1) * partSize);
-        dynamic obj = new ExpandoObject();
-        obj.partSize = partSize;
-        obj.partCount = partCount;
-        obj.lastPartSize = lastPartSize;
-        return obj;
+
+        return new MultiPartInfo { PartSize = partSize, PartCount = partCount, LastPartSize = lastPartSize };
     }
 
     /// <summary>

Minio/Minio.csproj

@@ -25,7 +25,6 @@
 		<PackageReference Include="System.ValueTuple" Version="4.5.0" />
 		<PackageReference Include="System.Text.Json" Version="7.0.3" />
 		<PackageReference Include="System.Security.Cryptography.Algorithms" Version="4.3.1" />
-		<PackageReference Include="Microsoft.CSharp" Version="4.7.0" />
 	</ItemGroup>
 
 </Project>