Fix build (#1222)

* Fix build

* attempt to fix functional test

* fix build issue

* Disabled IncompleteUpload tests

Author: ramondeklein

.github/workflows/minio-dotnet.yml

@@ -158,14 +158,15 @@ jobs:
       # Execute all functional tests in the solution
       - name: Execute Functional Tests Linux
         env:
+          CI: 1
           MINT_MODE: full
           SERVER_ENDPOINT: localhost:9000
           ACCESS_KEY: minio
           SECRET_KEY: minio123
           ENABLE_HTTPS: 1
           ENABLE_KMS: 1
-          MINIO_ACCESS_KEY: minio
-          MINIO_SECRET_KEY: minio123
+          MINIO_ROOT_USER: minio
+          MINIO_ROOT_PASSWORD: minio123
           MINIO_KMS_SECRET_KEY: my-minio-key:OSMM+vkKUTCvQs9YL/CVMIMt43HFhkUpqJxTmGl6rYw=
         run: |
             wget --quiet -O /tmp/minio https://dl.min.io/server/minio/release/linux-amd64/minio
@@ -175,6 +176,11 @@ jobs:
             sudo cp /tmp/minio-config/certs/public.crt /etc/ssl/certs/
             sudo cp /tmp/minio-config/certs/private.key /etc/ssl/private/
             /tmp/minio --certs-dir /tmp/minio-config/certs server /tmp/fs{1...4} &
+
+            wget --quiet -O /tmp/mc https://dl.min.io/client/mc/release/linux-amd64/mc
+            chmod +x /tmp/mc
+            MC_HOST_test=https://minio:minio123@localhost:9000 /tmp/mc --insecure ready test
+            
             dotnet Minio.Functional.Tests/bin/Release/net8.0/Minio.Functional.Tests.dll
 
   push_to_nuget:

FileUploader/FileUpload.cs

@@ -34,7 +34,7 @@ private static bool IsWindows()
         return OperatingSystem.IsWindows();
     }
 
-    private static async Task Main(string[] args)
+    private static async Task Main()
     {
         ServicePointManager.SecurityProtocol = SecurityProtocolType.Tls12
                                                | SecurityProtocolType.Tls11

Minio.Examples/Cases/GetBucketPolicy.cs

@@ -22,8 +22,7 @@ internal static class GetBucketPolicy
 {
     // Get bucket policy 
     public static async Task Run(IMinioClient minio,
-        string bucketName = "my-bucket-name",
-        string prefix = "")
+        string bucketName = "my-bucket-name")
     {
         try
         {

Minio.Examples/Cases/ListenBucketNotifications.cs

@@ -26,8 +26,7 @@ public static void Run(IMinioClient minio,
         string bucketName = "my-bucket-name",
         List<EventType> events = null,
         string prefix = "",
-        string suffix = "",
-        bool recursive = true)
+        string suffix = "")
     {
         try
         {

Minio.Examples/Cases/ListenNotifications.cs

@@ -1,4 +1,4 @@
-/*
+/*
  * MinIO .NET Library for Amazon S3 Compatible Cloud Storage, (C) 2024 MinIO, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
@@ -40,7 +40,7 @@ public static void Run(IMinioClient minio,
                 () => Console.WriteLine("Stopped listening for bucket notifications\n"));
 
             Console.WriteLine("Press any key to stop listening for notifications...");
-            Console.ReadLine();
+            _ = Console.ReadLine();
         }
         catch (Exception e)
         {

Minio.Examples/Cases/PresignedGetObject.cs

@@ -35,6 +35,6 @@ public static async Task Run(IMinioClient client,
             .WithObject(objectName)
             .WithExpiry(1000)
             .WithHeaders(reqParams);
-        var presignedUrl = await client.PresignedGetObjectAsync(args).ConfigureAwait(false);
+        _ = await client.PresignedGetObjectAsync(args).ConfigureAwait(false);
     }
 }

Minio.Examples/Cases/PresignedPostPolicy.cs

@@ -15,7 +15,6 @@
  */
 
 using Minio.DataModel;
-using Minio.DataModel.Args;
 
 namespace Minio.Examples.Cases;
 
@@ -34,14 +33,10 @@ public static async Task Run(IMinioClient client,
         form.SetBucket(bucketName);
         form.SetExpires(expiration);
 
-        var args = new PresignedPostPolicyArgs()
-            .WithBucket(bucketName)
-            .WithObject(objectName)
-            .WithPolicy(form);
-
         var tuple = await client.PresignedPostPolicyAsync(form).ConfigureAwait(false);
         var curlCommand = "curl -k --insecure -X POST";
         foreach (var pair in tuple.Item2) curlCommand += $" -F {pair.Key}={pair.Value}";
         curlCommand = curlCommand + " -F file=@/etc/issue " + tuple.Item1 + bucketName + "/";
+        _ = curlCommand;
     }
 }

Minio.Examples/Cases/SelectObjectContent.cs

@@ -26,8 +26,7 @@ internal static class SelectObjectContent
     // Get object in a bucket
     public static async Task Run(IMinioClient minio,
         string bucketName = "my-bucket-name",
-        string objectName = "my-object-name",
-        string fileName = "my-file-name")
+        string objectName = "my-object-name")
     {
         if (minio is null) throw new ArgumentNullException(nameof(minio));
 

Minio.Examples/Cases/StatObjectQuery.cs

@@ -59,8 +59,7 @@ public static async Task Run(IMinioClient minio,
         {
             var objectNameInfo = $"{bucketName}-{bucketObject}";
             if (!string.IsNullOrEmpty(versionID))
-                objectNameInfo = objectNameInfo +
-                                 $" (Version ID) {me.Response.VersionId} (Marked DEL) {me.Response.DeleteMarker}";
+                objectNameInfo += $" (Version ID) {me.Response.VersionId} (Marked DEL) {me.Response.DeleteMarker}";
 
             Console.WriteLine($"[StatObject] {objectNameInfo} Exception: {me}");
         }

Minio.Examples/Program.cs

@@ -123,7 +123,7 @@ public static async Task Main()
         for (var i = 0; i < 10; i++) objectsList.Add(objectName + i);
 
         // Set app Info 
-        minioClient.SetAppInfo("app-name", "app-version");
+        _ = minioClient.SetAppInfo("app-name", "app-version");
 
         // Set HTTP Tracing On
         // minioClient.SetTraceOn();