Replace deprecated ResizeBilinear for EAST #479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorHe-1
requested review from
tonytonglt,
HaoyangLee,
SamitHuang and
liangxhao
tonytonglt
approved these changes
Jul 4, 2023
liangxhao
approved these changes
Jul 5, 2023
HaoyangLee
approved these changes
Jul 5, 2023
hadipash
reviewed
Jul 5, 2023
| @@ -280,17 +280,17 @@ def __init__(self, in_channels, out_channels=128): | |||
| def construct(self, features): | |||
| f1, f2, f3, f4 = features | |||
|
|
|||
| out = ops.ResizeBilinear(f3.shape[2:], True)(f4) | |||
| out = ops.ResizeBilinearV2(True)(f4, f3.shape[2:]) | |||
There was a problem hiding this comment.
Will operator initialization inside construct affect execution speed in PyNative mode? Will it be better to initialize the operator once in __init__ (e.g. self.resize = ops.ResizeBilinearV2(True)) and then use it directly inside construct?
There was a problem hiding this comment.
Yes, it's better to define ops.ResizeBilinearV2(True) in __init__, then call it in the construct function. But I'm not sure if it will be a problem to export the existing ckpt file to MindIR after adding this line of code. The above codes are ok for the current ckpt file to export.
There was a problem hiding this comment.
I'll try it now
4 tasks
tonytonglt
pushed a commit
to tonytonglt/mindocr-fork
that referenced
this pull request
Jul 6, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the MindOCR repo.
Before submitting this PR, please make sure:
Motivation
Change this API to accept dynamic shape input
Test Plan
Already tested and model results are the same.
Related Issues and PRs
(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)