Skip to content

support show_log and save_log_dir #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2023
Merged

support show_log and save_log_dir #42

merged 1 commit into from
Mar 13, 2023

Conversation

liangxhao
Copy link
Contributor

@liangxhao liangxhao commented Mar 9, 2023

Thank you for your contribution to the MindOCR repo.
Before submitting this PR, please make sure:

Motivation

support show_log and save_log_dir

Test Plan

(How should this PR be tested? Do you require special setup to run the test or repro the fixed bug?)

Related Issues and PRs

(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)

@liangxhao
Copy link
Contributor Author

  1. when show_log=True, log info will be printed to the console
  2. when show_log=False, a progressbar(just for "input queue", not "output queue")will be displayed to the console

@SamitHuang SamitHuang requested a review from HaoyangLee March 10, 2023 15:37
@HaoyangLee
Copy link
Collaborator

look good to me

@HaoyangLee HaoyangLee merged commit c79c325 into mindspore-lab:main Mar 13, 2023
colawyee pushed a commit that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants