ignore permission checks with no origin

PalmerAL · PalmerAL · commit a3604e8feae9 · 2025-02-05T14:23:36.000-06:00
Some requests of this type started showing up after an Electron upgrade
diff --git a/main/permissionManager.js b/main/permissionManager.js
@@ -182,6 +182,11 @@ function pagePermissionCheckHandler (webContents, permission, requestingOrigin,
     return false
   }
 
+  // TODO sometimes the origin field is blank, figure out why
+  if (!requestingOrigin) {
+    return false
+  }
+
   if (permission === 'clipboard-sanitized-write') {
     return true
   }

Original file line number	Diff line number	Diff line change
`@@ -182,6 +182,11 @@ function pagePermissionCheckHandler (webContents, permission, requestingOrigin,`
`182`	`182`	`return false`
`183`	`183`	`}`
`184`	`184`
	`185`	`+ // TODO sometimes the origin field is blank, figure out why`
	`186`	`+ if (!requestingOrigin) {`
	`187`	`+ return false`
	`188`	`+ }`
	`189`	`+`
`185`	`190`	`if (permission === 'clipboard-sanitized-write') {`
`186`	`191`	`return true`
`187`	`192`	`}`