Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename domain as host? #33

Closed
bluestrike2 opened this issue Jul 14, 2012 · 2 comments
Closed

Rename domain as host? #33

bluestrike2 opened this issue Jul 14, 2012 · 2 comments

Comments

@bluestrike2
Copy link

Kind of a dumb question, but might I suggest renaming domain to host to better align with ssh conventions? Not really a big deal but given that the two don't necessarily line up it might avoid confusion for users (i.e., I'll use hosts in my ssh conf setup as deploy.hostname to handle the connection so I don't have to worry about it in a bunch of deploy files or others stick an IP in as :domain, etc.)

@rstacruz
Copy link
Member

We tried to follow Vlad's original names, and they called it :domain.

@bluestrike2
Copy link
Author

Lol, no worries then. Vlad obviously takes after its namesake. I'll close this, as like I said, it's more just a matter of nitpicking over consistency than any problem or concern. Thanks for explaining the background a bit on that! Makes a bit more sense now that I think of it (one of those d'oh! moments, I'm sure).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants