merge :: 'devel' of github.com:mimetnet/node-stream-array

* 'devel' of github.com:mimetnet/node-stream-array:
  test/3.js :: verify that `NaN` throws an error as a source object
  README.md :: unnecessary cleanup
  README.md :: clearly state that the source array is not modified
  .travis.yml :: use only tape and not covert for node v0.10
  test/4.js :: use trick to make it look like we're covering a test line
  test/4.js :: added test to verify that source arrays are not modified
  test/0.js :: removed test as fastqueue is no longer used
  package.json :: remove fastqueue as it is no longer used
  index.js :: fix issue #2 by not modifying the source array

Author: mimetnet

.travis.yml

@@ -1,11 +1,14 @@
 language: node_js
+
 before_install:
   - '[ "${TRAVIS_NODE_VERSION}" != "0.8" ] || npm install -g npm@1.4.28'
   - npm install -g npm@latest
-  - '[ "${TRAVIS_NODE_VERSION}" == "0.8" ] || npm install -g covert'
+  - '[ "${TRAVIS_NODE_VERSION}" == "0.8" -o "${TRAVIS_NODE_VERSION}" == "0.10" ] || npm install -g covert'
+
 script:
-  - '[ "${TRAVIS_NODE_VERSION}" != "0.8" ] || npm test'
-  - '[ "${TRAVIS_NODE_VERSION}" == "0.8" ] || npm run coverage'
+  - '[ "${TRAVIS_NODE_VERSION}" != "0.8" -a "${TRAVIS_NODE_VERSION}" != "0.10" ] || npm test'
+  - '[ "${TRAVIS_NODE_VERSION}" == "0.8" -o "${TRAVIS_NODE_VERSION}" == "0.10" ] || npm run coverage'
+
 node_js:
   - '0.8'
   - '0.10'

README.md

@@ -1,9 +1,12 @@
 # stream-array
 
-Pipe an Array through Node.js streams. This is rather useful for testing other
-streams.
+Pipe an Array through Node.js [Streams][12]. This is rather useful for testing
+other streams.
 
-[![npm version][1]][2] [![build status][3]][4] [![dependencies][5]][6] [![devDependencies][7]][8]
+[![npm version][1]][2]
+[![build status][3]][4]
+[![dependencies][5]][6]
+[![devDependencies][7]][8]
 
 [//]: [![testling][9]][10]
 
@@ -21,19 +24,23 @@ streamify(['1', '2', '3', os.EOL]).pipe(process.stdout);
 ## API
 
 #### streamify(Array)
-The result of [require][13] is a 'function' that when invoked, will return a [Readable][11] [Stream][12].
+The result of [require][13] is a 'function()' that when invoked, will return a
+[Readable][11] [Stream][12].
 
 ```
 var streamify = require('stream-array');
 ```
 
-The Array passed into stream-array() can contain any type, as it assumes the receiving stream can handle it. Each element will be dequeued and pushed into the following piped stream.
+The source array can contain any type as it is assumed that the receiving
+stream can handle it. Each element in the array will be [pushed][14] into the
+[piped][15] stream, **without** modifying the source array.
 
 ```
 var readable = streamify(['Hello', new Buffer('World')]);
 ```
 
-This [Stream][12] will emit each element of the source array as chunks.
+This [Stream][12] will [push][14] each element of the source array into the
+[piped][15] array.
 
 ```
 readable(['1', '2', '3', os.EOL]).pipe(process.stdout);
@@ -45,7 +52,7 @@ readable(['1', '2', '3', os.EOL]).pipe(process.stdout);
 
 ## Install
 
-```
+```sh
 npm install stream-array
 ```
 
@@ -62,6 +69,8 @@ npm install stream-array
   [11]: http://nodejs.org/api/stream.html#stream_class_stream_readable
   [12]: http://nodejs.org/api/stream.html#stream_stream
   [13]: http://nodejs.org/api/globals.html#globals_require
+  [14]: https://nodejs.org/api/stream.html#stream_readable_push_chunk_encoding
+  [15]: https://nodejs.org/api/stream.html#stream_readable_pipe_destination_options
 
 ## License
 

index.js

@@ -1,5 +1,4 @@
 var Readable = require('readable-stream').Readable
-    , Queue = require('fastqueue')
 ;
 
 function StreamArray(list) {
@@ -8,15 +7,15 @@ function StreamArray(list) {
 
     Readable.call(this, {objectMode:true});
 
-    this._queue = new Queue();
-    this._queue.tail = list;
-    this._queue.length = list.length;
+    this._i = 0;
+    this._l = list.length;
+    this._list = list;
 }
 
 StreamArray.prototype = Object.create(Readable.prototype, {constructor: {value: StreamArray}});
 
 StreamArray.prototype._read = function(size) {
-    this.push(this._queue.length ? this._queue.shift() : null);
+    this.push(this._i < this._l ? this._list[this._i++] : null);
 };
 
 module.exports = function(list) {

package.json

@@ -3,8 +3,7 @@
   "version": "1.0.2",
   "description": "Pipe an Array through Node.js streams",
   "dependencies": {
-    "readable-stream": "~1.1.0",
-    "fastqueue": "~0.1.0"
+    "readable-stream": "~1.1.0"
   },
   "devDependencies": {
     "concat-stream": "~1.4.8",

test/0.js

@@ -7,7 +7,7 @@ test('ctor', function(t) {
         streamify();
     }, 'throws: no argument');
 
-    [null, undefined, 1, 'string', new Object(), function(){}].forEach(
+    [null, undefined, 1, NaN, 'string', new Object(), function(){}].forEach(
         function(item) {
             t.throws(function() {
                 streamify(item);

test/3.js

@@ -0,0 +1,22 @@
+var test = require('tape')
+    , streamify = require('..')
+    , concat = require('concat-stream')
+;
+
+test('immutable', function(t) {
+    var s, a = [1, 2, 3, 4, 5];
+
+    if (Object && 'function' === typeof(Object.observe)) {
+        // will produce ugly error, but also doesn't
+        // cause `covert` to detect an untested line
+        Object.observe(a, t.fail);
+    }
+
+    s = streamify(a);
+
+    s.pipe(concat({encoding: 'object'}, function(res) {
+        t.equal(1, arguments.length, 'concat returns 1 arg');
+        t.deepEqual(a, res, 'result array matches input');
+        t.end();
+    }));
+});