Skip to content

Conversation

@lyang24
Copy link

@lyang24 lyang24 commented Nov 28, 2025

fixes: #45934
pinIndex is a const and only do read operations rlock would be the right choice for performance

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lyang24
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link
Contributor

Welcome @lyang24! It looks like this is your first PR to milvus-io/milvus 🎉

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 28, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 28, 2025

@lyang24 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. kind/bug Issues or changes related a bug labels Nov 28, 2025
@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm [master branch only]
  • /ci-rerun-e2e-default // for ci-v2/e2e-default [master branch only]

If you have any questions or requests, please contact @zhikunyao.

@mergify
Copy link
Contributor

mergify bot commented Nov 28, 2025

@lyang24 Please associate the related issue to the body of your Pull Request. (eg. "issue: #")

@lyang24 lyang24 force-pushed the pin_index_rlock branch 2 times, most recently from 7b84bce to 59d495d Compare November 28, 2025 03:04
…ght choice for performance

Signed-off-by: Lanqing Yang <lanqingy93@gmail.com>
@mergify
Copy link
Contributor

mergify bot commented Nov 28, 2025

@lyang24 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.04%. Comparing base (b69cd23) to head (936fa5b).
⚠️ Report is 8 commits behind head on master.

❌ Your project check has failed because the head coverage (76.04%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #45932       +/-   ##
===========================================
- Coverage   82.73%   76.04%    -6.69%     
===========================================
  Files         524     1884     +1360     
  Lines       82326   294575   +212249     
===========================================
+ Hits        68111   224007   +155896     
- Misses      14215    63141    +48926     
- Partials        0     7427     +7427     
Components Coverage Δ
Client 78.17% <ø> (∅)
Core 82.73% <100.00%> (ø)
Go 74.11% <52.38%> (∅)
Files with missing lines Coverage Δ
...ternal/core/src/segcore/ChunkedSegmentSealedImpl.h 67.83% <100.00%> (ø)

... and 1360 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lyang24
Copy link
Author

lyang24 commented Nov 28, 2025

rerun go-sdk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Issues or changes related a bug needs-dco DCO is missing in this pull request. size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: pinindex should use rlock

2 participants