-
Notifications
You must be signed in to change notification settings - Fork 3.6k
fix: use rlock for pinindex #45932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: use rlock for pinindex #45932
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lyang24 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @lyang24! It looks like this is your first PR to milvus-io/milvus 🎉 |
|
@lyang24 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
|
[ci-v2-notice]
To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
|
@lyang24 Please associate the related issue to the body of your Pull Request. (eg. "issue: #") |
7b84bce to
59d495d
Compare
…ght choice for performance Signed-off-by: Lanqing Yang <lanqingy93@gmail.com>
59d495d to
936fa5b
Compare
|
@lyang24 go-sdk check failed, comment |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (76.04%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #45932 +/- ##
===========================================
- Coverage 82.73% 76.04% -6.69%
===========================================
Files 524 1884 +1360
Lines 82326 294575 +212249
===========================================
+ Hits 68111 224007 +155896
- Misses 14215 63141 +48926
- Partials 0 7427 +7427
🚀 New features to boost your workflow:
|
|
rerun go-sdk |
fixes: #45934
pinIndex is a const and only do read operations rlock would be the right choice for performance