Skip to content

Conversation

@murataslan1
Copy link

Summary

This PR fixes the docker-compose-apple-silicon.yml configuration to ensure etcd data is properly persisted and services are properly configured.

Changes

  • Added healthcheck for etcd service to ensure proper startup detection
  • Added container_name for etcd, pulsar, and minio services for consistency with standalone docker-compose
  • Aligned configuration with deployments/docker/standalone/docker-compose.yml

Testing

The changes align the Apple Silicon docker-compose configuration with the working standalone configuration.

Related Issue

Fixes #45174

murataslan1 and others added 2 commits November 28, 2025 02:38
…client

Add support for HNSW_SQ, HNSW_PQ, and HNSW_PRQ index types in the Go client
to match the Python SDK functionality.

- Add HNSWSQ, HNSWPQ, and HNSWPRQ index type constants
- Implement NewHNSWSQIndex with sq_type and optional refine support
- Implement NewHNSWPQIndex with pqM, nbits and optional refine support
- Implement NewHNSWPRQIndex with pqM, nbits and optional refine support
- Add NewHNSWQuantAnnParam for search with refine_k parameter

Fixes milvus-io#44635

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
…ker-compose

- Add healthcheck for etcd service to ensure proper startup detection
- Add container_name for etcd, pulsar, and minio services for consistency
- Align configuration with standalone docker-compose.yml

Fixes milvus-io#45174

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: murataslan1
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 27, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 27, 2025

@murataslan1 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Nov 27, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 27, 2025

@murataslan1

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  • build(deps): for dependency updates from Dependabot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm [master branch only]
  • /ci-rerun-e2e-default // for ci-v2/e2e-default [master branch only]

If you have any questions or requests, please contact @zhikunyao.

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.73%. Comparing base (b69cd23) to head (60832c8).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #45925   +/-   ##
=======================================
  Coverage   82.73%   82.73%           
=======================================
  Files         524      524           
  Lines       82326    82326           
=======================================
  Hits        68111    68111           
  Misses      14215    14215           
Components Coverage Δ
Client ∅ <ø> (∅)
Core 82.73% <ø> (ø)
Go ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/invalid-pr-format needs-dco DCO is missing in this pull request. size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: etcd data not persisted in docker-compose-apple-silicon.yml

2 participants