-
Notifications
You must be signed in to change notification settings - Fork 3.6k
fix(docker): add healthcheck and container names to apple-silicon docker-compose #45925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(docker): add healthcheck and container names to apple-silicon docker-compose #45925
Conversation
…client Add support for HNSW_SQ, HNSW_PQ, and HNSW_PRQ index types in the Go client to match the Python SDK functionality. - Add HNSWSQ, HNSWPQ, and HNSWPRQ index type constants - Implement NewHNSWSQIndex with sq_type and optional refine support - Implement NewHNSWPQIndex with pqM, nbits and optional refine support - Implement NewHNSWPRQIndex with pqM, nbits and optional refine support - Add NewHNSWQuantAnnParam for search with refine_k parameter Fixes milvus-io#44635 Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
…ker-compose - Add healthcheck for etcd service to ensure proper startup detection - Add container_name for etcd, pulsar, and minio services for consistency - Align configuration with standalone docker-compose.yml Fixes milvus-io#45174 Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: murataslan1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@murataslan1 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
|
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure: Where Example: Please review and update your PR to comply with these guidelines. |
|
[ci-v2-notice]
To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #45925 +/- ##
=======================================
Coverage 82.73% 82.73%
=======================================
Files 524 524
Lines 82326 82326
=======================================
Hits 68111 68111
Misses 14215 14215
🚀 New features to boost your workflow:
|
Summary
This PR fixes the docker-compose-apple-silicon.yml configuration to ensure etcd data is properly persisted and services are properly configured.
Changes
healthcheckfor etcd service to ensure proper startup detectioncontainer_namefor etcd, pulsar, and minio services for consistency with standalone docker-composedeployments/docker/standalone/docker-compose.ymlTesting
The changes align the Apple Silicon docker-compose configuration with the working standalone configuration.
Related Issue
Fixes #45174