Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add expression template tests and use error msg only as assertion #37618

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

yanliang567
Copy link
Contributor

related issue: #37451

Signed-off-by: yanliang567 <yanliang.qiao@zilliz.com>
Signed-off-by: yanliang567 <yanliang.qiao@zilliz.com>
Signed-off-by: yanliang567 <yanliang.qiao@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Nov 12, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yanliang567

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Nov 12, 2024

@yanliang567 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: yanliang567 <yanliang.qiao@zilliz.com>
@mergify mergify bot added the ci-passed label Nov 13, 2024
Copy link
Contributor

@wangting0128 wangting0128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot merged commit af433ff into milvus-io:master Nov 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants