Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: enable multiple chunked segment by default #37570

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Nov 11, 2024

No description provided.

Signed-off-by: sunby <sunbingyi1992@gmail.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 11, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 11, 2024
Copy link
Contributor

mergify bot commented Nov 11, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.13%. Comparing base (a031578) to head (eba6dca).
Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/segcore/SegmentChunkReader.cpp 0.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (a031578) and HEAD (eba6dca). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (a031578) HEAD (eba6dca)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37570       +/-   ##
===========================================
- Coverage   80.59%   68.13%   -12.46%     
===========================================
  Files        1356      290     -1066     
  Lines      189208    25392   -163816     
===========================================
- Hits       152489    17302   -135187     
+ Misses      31362     8090    -23272     
+ Partials     5357        0     -5357     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 68.13% <0.00%> (+<0.01%) ⬆️
Go ∅ <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/segcore/SegmentChunkReader.cpp 26.70% <0.00%> (+0.41%) ⬆️

... and 1066 files with indirect coverage changes

Signed-off-by: sunby <sunbingyi1992@gmail.com>
@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Nov 11, 2024
@mergify mergify bot added the ci-passed label Nov 11, 2024
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sunby, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c1eccce into milvus-io:master Nov 12, 2024
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants