Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add segment/channel/task/slow query render #37561

Merged
merged 1 commit into from
Nov 12, 2024
Merged

feat: add segment/channel/task/slow query render #37561

merged 1 commit into from
Nov 12, 2024

Conversation

jaime0815
Copy link
Contributor

issue: #36621

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Nov 9, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Nov 9, 2024
@jaime0815 jaime0815 force-pushed the webui-render-segment-channel-task branch from 00e6cba to 1e1aac5 Compare November 9, 2024 15:05
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 9, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Nov 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.13%. Comparing base (b5b0035) to head (31be4f6).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #37561   +/-   ##
=======================================
  Coverage   68.13%   68.13%           
=======================================
  Files         290      290           
  Lines       25392    25392           
=======================================
  Hits        17302    17302           
  Misses       8090     8090
Components Coverage Δ
Client ∅ <ø> (∅)
Core 68.13% <ø> (ø)
Go ∅ <ø> (∅)

@jaime0815 jaime0815 force-pushed the webui-render-segment-channel-task branch from 1e1aac5 to 74402c7 Compare November 11, 2024 04:09
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 11, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@jaime0815 jaime0815 force-pushed the webui-render-segment-channel-task branch from 74402c7 to 2ef512f Compare November 11, 2024 06:22
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 11, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815 jaime0815 force-pushed the webui-render-segment-channel-task branch from 2ef512f to bdbd1b1 Compare November 11, 2024 08:03
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 11, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@SimFG
Copy link
Contributor

SimFG commented Nov 11, 2024

/lgtm

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 11, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 11, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 11, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 12, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815 jaime0815 force-pushed the webui-render-segment-channel-task branch from bdbd1b1 to ec435ce Compare November 12, 2024 04:21
@sre-ci-robot sre-ci-robot removed the lgtm label Nov 12, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 12, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815 jaime0815 force-pushed the webui-render-segment-channel-task branch from ec435ce to ab158f6 Compare November 12, 2024 05:56
@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Nov 12, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 12, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
feat: add segment/channel/task/slow query render
31be4f6 
Signed-off-by: jaime <yun.zhang@zilliz.com>
@jaime0815 jaime0815 force-pushed the webui-render-segment-channel-task branch from ab158f6 to 31be4f6 Compare November 12, 2024 07:18
@mergify mergify bot added the ci-passed label Nov 12, 2024
SimFG
SimFG reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@SimFG SimFG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot merged commit 1e8ea4a into milvus-io:master Nov 12, 2024
18 of 20 checks passed
@jaime0815 jaime0815 deleted the webui-render-segment-channel-task branch November 12, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimFG SimFG SimFG left review comments

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@congqixia congqixia Awaiting requested review from congqixia

Assignees

@SimFG SimFG

Labels
approved area/dependency Pull requests that update a dependency file area/test ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm sig/testing size/XXL Denotes a PR that changes 1000+ lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaime0815 @sre-ci-robot @SimFG