Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add openai embedding #36366

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

feat: Add openai embedding #36366

wants to merge 9 commits into from
+2,325 −10

Conversation

junjiejiangjjj
Copy link

@junjiejiangjjj junjiejiangjjj commented Sep 19, 2024 •
edited
Loading

@sre-ci-robot sre-ci-robot added the do-not-merge/work-in-progress Don't merge even CI passed. label Sep 19, 2024
@sre-ci-robot
Copy link
Contributor

Welcome @junjiejiangjjj! It looks like this is your first PR to milvus-io/milvus 🎉

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Sep 19, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Sep 19, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 19, 2024

@junjiejiangjjj Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@junjiejiangjjj junjiejiangjjj mentioned this pull request Sep 19, 2024
Open
1 task
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Sep 23, 2024
@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Sep 26, 2024
@junjiejiangjjj junjiejiangjjj force-pushed the embedding branch 2 times, most recently from 38243dd to 0d0286e Compare October 8, 2024 08:26
@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Oct 8, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.13%. Comparing base (7cfd609) to head (169ba8d).
Report is 57 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #36366       +/-   ##
===========================================
- Coverage   83.23%   68.13%   -15.10%     
===========================================
  Files        1015      290      -725     
  Lines      157697    25392   -132305     
===========================================
- Hits       131260    17302   -113958     
+ Misses      21228     8090    -13138     
+ Partials     5209        0     -5209
Components Coverage Δ
Client ∅ <ø> (∅)
Core 68.13% <47.76%> (∅)
Go ∅ <ø> (∅)

see 1305 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 28, 2024

@junjiejiangjjj E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 28, 2024

@junjiejiangjjj go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 28, 2024

@junjiejiangjjj E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@junjiejiangjjj go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@junjiejiangjjj E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@junjiejiangjjj E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@junjiejiangjjj cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@junjiejiangjjj go-sdk check failed, comment rerun go-sdk can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@junjiejiangjjj go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@junjiejiangjjj E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@junjiejiangjjj junjiejiangjjj mentioned this pull request Nov 7, 2024
Merged
@junjiejiangjjj
Add openai embedding client
2eb7ba7 
Signed-off-by: junjie.jiang <junjie.jiang@zilliz.com>
@junjiejiangjjj
Add embedding runner
7375194 
Signed-off-by: junjie.jiang <junjie.jiang@zilliz.com>
@junjiejiangjjj
Add function executor
a049a92 
Signed-off-by: junjie.jiang <junjie.jiang@zilliz.com>
@junjiejiangjjj
Insert & Upsert support functions
8a1d569 
Signed-off-by: junjie.jiang <junjie.jiang@zilliz.com>
@junjiejiangjjj
Search supports embedding function
bea808c 
Signed-off-by: junjie.jiang <junjie.jiang@zilliz.com>
@junjiejiangjjj
Add search embedding test
939698e 
Signed-off-by: junjie.jiang <junjie.jiang@zilliz.com>
@junjiejiangjjj
Support bulkinsert
5299478 
Signed-off-by: junjie.jiang <junjie.jiang@zilliz.com>
@junjiejiangjjj
Use TextEmbedding function
f54e469 
Signed-off-by: junjie.jiang <junjie.jiang@zilliz.com>
@junjiejiangjjj
update
169ba8d 
Signed-off-by: junjiejiangjjj <junjie.jiang@zilliz.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 7, 2024

@junjiejiangjjj cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@junjiejiangjjj
Copy link
Author

junjiejiangjjj commented Nov 12, 2024 •
edited
Loading

rerun cpp-unit-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhengbuqian zhengbuqian zhengbuqian left review comments

@czs007 czs007 Awaiting requested review from czs007

@zwd1208 zwd1208 Awaiting requested review from zwd1208

Assignees

@zhengbuqian zhengbuqian

@czs007 czs007

@liliu-z liliu-z

Labels
area/dependency Pull requests that update a dependency file dco-passed DCO check passed. kind/feature Issues related to feature request from users size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@junjiejiangjjj @sre-ci-robot @zhengbuqian @czs007 @liliu-z