Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Support otlp http exporter (#35053) #35073

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #35053
See also #35052

See also milvus-io#35052

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added approved size/M Denotes a PR that changes 30-99 lines. labels Jul 29, 2024
@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Jul 29, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Jul 29, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 31.81818% with 30 lines in your changes missing coverage. Please review.

Project coverage is 81.12%. Comparing base (4138a9f) to head (869197b).
Report is 1 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35073      +/-   ##
==========================================
- Coverage   84.84%   81.12%   -3.73%     
==========================================
  Files         786     1046     +260     
  Lines      113264   137055   +23791     
==========================================
+ Hits        96101   111186   +15085     
- Misses      12965    21661    +8696     
- Partials     4198     4208      +10     
Files Coverage Δ
internal/core/src/common/Tracer.h 100.00% <ø> (ø)
internal/core/src/common/init_c.cpp 0.00% <ø> (ø)
internal/util/initcore/init_core.go 90.54% <100.00%> (+0.39%) ⬆️
pkg/util/paramtable/component_param.go 98.54% <100.00%> (+<0.01%) ⬆️
internal/core/src/common/Tracer.cpp 72.15% <0.00%> (ø)
pkg/tracer/tracer.go 65.57% <0.00%> (-12.86%) ⬇️

... and 283 files with indirect coverage changes

@congqixia congqixia added this to the 2.4.7 milestone Jul 30, 2024
@mergify mergify bot removed the ci-passed label Jul 30, 2024
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@xiaofan-luan xiaofan-luan merged commit 935a117 into milvus-io:2.4 Jul 30, 2024
9 of 12 checks passed
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [congqixia,xiaofan-luan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

congqixia added a commit to congqixia/milvus that referenced this pull request Jul 31, 2024
See also milvus-io#35073 milvus-io#35119

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Jul 31, 2024
See also #35073 #35119

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia deleted the cp24/35053 branch August 2, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants