Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Support otlp http exporter #35053

Merged

Conversation

congqixia
Copy link
Contributor

See also #35052

See also milvus-io#35052

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Jul 29, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/M Denotes a PR that changes 30-99 lines. labels Jul 29, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Jul 29, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 31.81818% with 30 lines in your changes missing coverage. Please review.

Project coverage is 81.04%. Comparing base (9a07790) to head (9c6d373).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #35053       +/-   ##
===========================================
+ Coverage   70.12%   81.04%   +10.92%     
===========================================
  Files        1189     1184        -5     
  Lines      143352   143751      +399     
===========================================
+ Hits       100520   116498    +15978     
+ Misses      38419    22839    -15580     
- Partials     4413     4414        +1     
Files Coverage Δ
internal/core/src/common/Tracer.h 100.00% <ø> (+100.00%) ⬆️
internal/core/src/common/init_c.cpp 0.00% <ø> (ø)
internal/util/initcore/init_core.go 90.54% <100.00%> (+0.39%) ⬆️
pkg/util/paramtable/component_param.go 98.56% <100.00%> (+<0.01%) ⬆️
internal/core/src/common/Tracer.cpp 72.15% <0.00%> (+72.15%) ⬆️
pkg/tracer/tracer.go 65.57% <0.00%> (-12.86%) ⬇️

... and 301 files with indirect coverage changes

@aoiasd
Copy link
Contributor

aoiasd commented Jul 29, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 9727522 into milvus-io:master Jul 29, 2024
10 of 12 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Jul 29, 2024
See also milvus-io#35052

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
OxalisCu pushed a commit to OxalisCu/milvus that referenced this pull request Jul 30, 2024
See also milvus-io#35052

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
xiaofan-luan pushed a commit that referenced this pull request Jul 30, 2024
Cherry-pick from master
pr: #35053
See also #35052

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia deleted the enhance/support_otlp_http_exporter branch August 2, 2024 06:47
sumitd2 pushed a commit to sumitd2/milvus that referenced this pull request Aug 6, 2024
See also milvus-io#35052

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants