Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1660 IVFPQ has supported to delete vectors #1722

Merged
merged 2 commits into from
Mar 23, 2020

Conversation

shengjun1985
Copy link
Contributor

Signed-off-by: shengjun.li shengjun.li@zilliz.com

What type of PR is this?
feature

What this PR does / why we need it:
IVFPQ has supported to delete vectors

Which issue(s) this PR fixes:
Fixes #1660

Special notes for your reviewer:
yhmo; youny626

Does this PR introduce a user-facing change?:
Yes

Additional documentation (e.g. design docs, usage docs, etc.):
None

Signed-off-by: shengjun.li <shengjun.li@zilliz.com>
@shengjun1985 shengjun1985 changed the title IVFPQ has supported to delete vectors #1660 IVFPQ has supported to delete vectors Mar 21, 2020
@shengjun1985 shengjun1985 requested review from yhmo and youny626 March 21, 2020 06:40
@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@4505738). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1722   +/-   ##
=========================================
  Coverage          ?   92.29%           
=========================================
  Files             ?      379           
  Lines             ?    22407           
  Branches          ?        0           
=========================================
  Hits              ?    20681           
  Misses            ?     1726           
  Partials          ?        0
Flag Coverage Δ
#cpu_version_centos7_unittest 92.05% <0%> (?)
#gpu_version_centos7_unittest 91.97% <0%> (?)
Impacted Files Coverage Δ
.../src/server/delivery/request/DeleteByIDRequest.cpp 58.62% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4505738...01309c2. Read the comment docs.

@JinHai-CN JinHai-CN merged commit e3786a2 into milvus-io:master Mar 23, 2020
@shengjun1985 shengjun1985 deleted the pq_delete branch March 27, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IVF PQ CPU support deleted vectors searching.
2 participants