From 57ad465eb143ab72bae5e4a1f20a7ab51a3800a0 Mon Sep 17 00:00:00 2001 From: "xianliang.li" Date: Thu, 7 Nov 2024 17:46:21 +0800 Subject: [PATCH] update knowhere version Signed-off-by: xianliang.li --- internal/core/thirdparty/knowhere/CMakeLists.txt | 2 +- internal/util/indexparamcheck/float_vector_base_checker_test.go | 2 +- internal/util/indexparamcheck/hnsw_checker_test.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/core/thirdparty/knowhere/CMakeLists.txt b/internal/core/thirdparty/knowhere/CMakeLists.txt index 48f079faa126c..3303560932589 100644 --- a/internal/core/thirdparty/knowhere/CMakeLists.txt +++ b/internal/core/thirdparty/knowhere/CMakeLists.txt @@ -14,7 +14,7 @@ # Update KNOWHERE_VERSION for the first occurrence milvus_add_pkg_config("knowhere") set_property(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} PROPERTY INCLUDE_DIRECTORIES "") -set( KNOWHERE_VERSION e67abe7 ) +set( KNOWHERE_VERSION 9e6af18 ) set( GIT_REPOSITORY "https://github.com/zilliztech/knowhere.git") message(STATUS "Knowhere repo: ${GIT_REPOSITORY}") message(STATUS "Knowhere version: ${KNOWHERE_VERSION}") diff --git a/internal/util/indexparamcheck/float_vector_base_checker_test.go b/internal/util/indexparamcheck/float_vector_base_checker_test.go index 7a1bf3c6d29da..7306db92b0df2 100644 --- a/internal/util/indexparamcheck/float_vector_base_checker_test.go +++ b/internal/util/indexparamcheck/float_vector_base_checker_test.go @@ -63,7 +63,7 @@ func Test_floatVectorBaseChecker_CheckValidDataType(t *testing.T) { }, { dType: schemapb.DataType_BinaryVector, - errIsNil: true, + errIsNil: false, }, } diff --git a/internal/util/indexparamcheck/hnsw_checker_test.go b/internal/util/indexparamcheck/hnsw_checker_test.go index 0ed41375ad631..fbb33dc3b0c7a 100644 --- a/internal/util/indexparamcheck/hnsw_checker_test.go +++ b/internal/util/indexparamcheck/hnsw_checker_test.go @@ -165,7 +165,7 @@ func Test_hnswChecker_CheckValidDataType(t *testing.T) { }, { dType: schemapb.DataType_BinaryVector, - errIsNil: true, + errIsNil: false, }, }