diff --git a/Makefile b/Makefile index d727dc2cfe6d7..62b11ce282b7c 100644 --- a/Makefile +++ b/Makefile @@ -111,6 +111,11 @@ build-cpp-with-unittest: # Run the tests. unittest: test-cpp test-go +test-proxy: + @echo "Running go unittests..." + go test -race -coverpkg=./... -coverprofile=profile.out -covermode=atomic -timeout 5m github.com/milvus-io/milvus/internal/proxy -v + + test-go: build-cpp-with-unittest @echo "Running go unittests..." @(env bash $(PWD)/scripts/run_go_codecov.sh) diff --git a/internal/querycoord/task.go b/internal/querycoord/task.go index ff552abe41629..fdc7354d16bef 100644 --- a/internal/querycoord/task.go +++ b/internal/querycoord/task.go @@ -1356,7 +1356,7 @@ func (wqt *watchQueryChannelTask) execute(ctx context.Context) error { err := wqt.cluster.addQueryChannel(wqt.ctx, wqt.NodeID, wqt.AddQueryChannelRequest) if err != nil { - log.Warn("watchQueryChannelTask: watchQueryChannel occur error", zap.Int64("taskID", wqt.getTaskID())) + log.Warn("watchQueryChannelTask: watchQueryChannel occur error", zap.Int64("taskID", wqt.getTaskID()), zap.Error(err)) wqt.setResultInfo(err) return err } diff --git a/internal/querynode/collection_replica.go b/internal/querynode/collection_replica.go index 61dbee869863e..d214bf6fa32d8 100644 --- a/internal/querynode/collection_replica.go +++ b/internal/querynode/collection_replica.go @@ -182,7 +182,7 @@ func (colReplica *collectionReplica) getCollectionByID(collectionID UniqueID) (* func (colReplica *collectionReplica) getCollectionByIDPrivate(collectionID UniqueID) (*Collection, error) { collection, ok := colReplica.collections[collectionID] if !ok { - return nil, errors.New("collection hasn't been loaded or has been released, collection id = %d" + strconv.FormatInt(collectionID, 10)) + return nil, errors.New("collection hasn't been loaded or has been released, collection id =" + strconv.FormatInt(collectionID, 10)) } return collection, nil