Skip to content

Fix build with gcc 8.3.0.#123

Open
mity wants to merge 1 commit into
miloyip:masterfrom
mity:fix-build
Open

Fix build with gcc 8.3.0.#123
mity wants to merge 1 commit into
miloyip:masterfrom
mity:fix-build

Conversation

@mity

@mity mity commented Jan 16, 2020

Copy link
Copy Markdown

This fixes #102 (comment) (the issue in the 1st post there.)

func() and std::func() may conflict, depending on what C++ options
or stanadard or whatever the code including the header uses.
@mloskot

mloskot commented Jan 19, 2020

Copy link
Copy Markdown

This still does not make the whole thing build and run successfully, does it?

@mity

mity commented Jan 19, 2020

Copy link
Copy Markdown
Author

This still does not make the whole thing build and run successfully, does it?

No, it does not.

To make it build and run on my Linux machine, I also had to disable about 10 parser implementations which either did not build or which were crashing the tests.

I didn't want to mix that with this PR because maybe they do work on some other platform(s) and disabling them is not really a fix.

@mloskot

mloskot commented Jan 19, 2020

Copy link
Copy Markdown

This still does not make the whole thing build and run successfully, does it?

No, it does not.

OK. I was double-checking what's the status of the repo.

To make it build and run on my Linux machine, I also had to disable about 10 parser implementations which either did not build or which were crashing the tests.

Yup, I confirm it's needed (as per detailed in comments to #102).

Thanks.

@mity

mity commented Jan 19, 2020

Copy link
Copy Markdown
Author

If you find it useful, https://github.com/mity/nativejson-benchmark (master) now contains all the fixes (and addition of Centijson) I needed to make it work on my machine.

Don't be fooled though: I use it now for checking my JSON implementation but I have no intention to maintain the benchmark in the long term.

@mloskot

mloskot commented Jan 19, 2020

Copy link
Copy Markdown

@mity Thanks. I did similar and have fixed branch in my fork :) Not to be maintained in long term either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build fails on Linux (both x64 and x32)

2 participants