Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it work with --group #94

Closed
npearson72 opened this issue Oct 1, 2013 · 9 comments
Closed

Make it work with --group #94

npearson72 opened this issue Oct 1, 2013 · 9 comments

Comments

@npearson72
Copy link

Any chance to make this work with --group not just --nogroup?

--group looks nicer, more like Sublime text

@KJlmfe
Copy link

KJlmfe commented Nov 22, 2013

agree with @npearson72 and hope that it works with --color

@fmarkwong
Copy link

+1. group and color would be sweet. basically making it look like the output in a color terminal. Thanks for a great plugin!

@kassio
Copy link
Contributor

kassio commented Mar 21, 2014

The best way that I found to group result was using fold, I got a result like that:

screenshot from 2014-03-20 23 31 21

WDYT?

I found it on vim.wikia

@kassio
Copy link
Contributor

kassio commented Mar 21, 2014

I can add an option to auto fold results, would that be enough?

@npearson72
Copy link
Author

I think what’s nice about the group option is that you see all the results, but they’re displayed in indented format as a group under each file.

On Mar 20, 2014, at 7:33 PM, Kassio Borges notifications@github.com wrote:

I can add an option to auto fold results, would that be enough?


Reply to this email directly or view it on GitHub.

@kassio
Copy link
Contributor

kassio commented Mar 21, 2014

I don't think it is possible with quickfix windows or location list windows. If you found a way to do this, please open a pull request. Thank's for the suggestion.

@albfan
Copy link

albfan commented Jun 20, 2016

Take a look on its screencast (it's worth to see)

https://github.com/albfan/ag.vim#shell-mimic

It comes from a previous fork for ag (unmaintained now)

So if you find it interesting I can rework that pull request for this plugin.

@ches
Copy link
Collaborator

ches commented Jun 20, 2016

@kassio did end up implementing something like this @albfan, let g:ack_autofold_results = 1. It does have a valid problem though (#138) that I would like to address but just haven't taken the time yet, I don't use this feature myself.

I just shared my feelings about significant new features on an ag.vim thread that you're part of, but this is an existing feature so if you feel there are improvements in your implementation, I'm happy to review a pull request bringing the improvements to ack.vim (I haven't looked at your impl yet, but a workaround like the one Konfect suggested on #138 seems perfectly reasonable to me if you've already done something like it).

@albfan
Copy link

albfan commented Jun 20, 2016

That's a good start point. Fixing something will help to understand codebase. I'll work on it and see what can be done.

I'm agree with "less is more" so let's keep this as simple and lightweight as possible, and discuss on new PR worth of new features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants