Skip to content

Conversation

@mikmog
Copy link
Owner

@mikmog mikmog commented Feb 9, 2025

Up nugets backend

Summary by CodeRabbit

  • Chores

    • Updated several internal dependency versions to enhance stability and compatibility.
    • Added an extra package to support improved URI handling.
  • Tests

    • Refined the testing environment configuration with an updated container image version for more consistent performance.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 9, 2025

📝 Walkthrough

Walkthrough

This pull request updates key dependency configurations and environment settings. The SQL Server container image in the SharedTestDbFixture is upgraded from 2022-CU14-ubuntu-22.04 to 2022-CU17-ubuntu-22.04. The Directory.Packages.props file sees several package version changes—including Azure, Microsoft, and xunit dependencies—with some packages replaced by newer versions. Additionally, a new package reference for System.Private.Uri is added in the Functions project file. There are no changes to public APIs or business logic.

Changes

File Change Summary
src/backend/…/SharedTestDbFixture.cs Updated SQL Server container image version from 2022-CU14-ubuntu-22.04 to 2022-CU17-ubuntu-22.04 during test container initialization.
src/backend/…/Directory.Packages.props Upgraded multiple package versions (e.g., Azure.Extensions.AspNetCore.Configuration.Secrets 1.3.2→1.4.0, Azure.Identity 1.13.1→1.13.2, coverlet.collector 6.0.2→6.0.4, etc.), replaced several Microsoft.* packages, and updated xunit references.
src/backend/…/Ts.Functions.csproj Added a new package reference for System.Private.Uri within the project’s package references.

Possibly related PRs

  • Fix tests #27: Addresses updates in the SharedTestDbFixture class related to the SQL Server container initialization, making it closely connected to the current changes.

Poem

Hoppity hop, I code away,
Docker images now leap ahead today,
Packages updated, shining so bright,
New dependencies join the flight,
A rabbit cheers our code in delight!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9065051 and eaa9622.

📒 Files selected for processing (3)
  • src/backend/Database/Ts.Database.Tests/SharedTestDbFixture.cs (1 hunks)
  • src/backend/Directory.Packages.props (2 hunks)
  • src/backend/Functions/Ts.Functions/Ts.Functions.csproj (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/backend/Database/Ts.Database.Tests/SharedTestDbFixture.cs
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: build-and-publish / Build & Test
  • GitHub Check: Analyze (csharp)
🔇 Additional comments (4)
src/backend/Directory.Packages.props (3)

20-20: Reconsider using preview package in production

Using preview package Microsoft.Extensions.Caching.Hybrid (9.1.0-preview.1.25064.3) in production code may lead to instability.

Consider using the latest stable version instead.


8-9: 🏁 Script executed:

#!/bin/bash
# Check for any package dependency conflicts
dotnet list package --vulnerable

Length of output: 131


19-19: Verify breaking changes in Microsoft.Data.SqlClient 6.0.1

The major version bump (5.2.2 -> 6.0.1) may introduce breaking changes.

✅ Verification successful

🌐 Web query:

What are the breaking changes in Microsoft.Data.SqlClient 6.0.1 compared to 5.x?

💡 Result:

Microsoft.Data.SqlClient 6.0 introduced several breaking changes compared to earlier versions in the Microsoft.Data.SqlClient series (v5.x and below). Here are the key compatibility considerations when upgrading:

## Breaking Changes in v6.x vs v5.x
- **Dropped platform support**:
    - **Removed .NET Standard support** (#2386)[1][3]
    - **Ended support for .NET Framework <4.6.2** (previously supported until v5.x)[1][3]
    - **Dropped UWP (Universal Windows Platform)** references (#2483)[1][4]
    - **Removed SQL Server 2000 client-side debugging** (.NET Framework only) (#2981)[1][4]

- **Authentication changes**:
    - **Active Directory Managed Identity authentication** now requires `ClientId` instead of `ObjectId`[3][4]

- **Connection behavior modifications**:
    - `Encrypt` connection string property now defaults to `true` (changed from `false`)[3][4]
    - `SqlBulkCopy` now uses `RowsCopied64` instead of `RowsCopied` for large operations[3][4]

## Target Platform Requirements
| Version | Supported Platforms |
|---------|----------------------|
| v5.x    | .NET Framework ≥4.6<br>.NET Core ≥2.1<br>.NET Standard ≥2 |
| v6.x    | **Windows**:<br>- .NET Framework ≥4.6.2<br>- .NET ≥8<br>**Cross-Platform**:<br>- Linux/macOS with .NET ≥8 |

## Migration Considerations
Projects using these features will require updates:
- UWP applications must migrate to newer Windows app frameworks[1]
- Applications targeting EOL frameworks (.NET ≤8) need framework upgrades[3][8]
- SQL Server debugging workflows require alternative tools[1][4]

For projects requiring legacy platform support, Microsoft recommends staying on v5.x until infrastructure can be updated[7][8]. The v5.x branch will receive security updates until August 2027[7].

Citations:

- 1: https://learn.microsoft.com/en-us/sql/connect/ado-net/introduction-microsoft-data-sqlclient-namespace?view=sql-server-ver15
- 2: https://www.nuget.org/packages/System.Data.SqlClient
- 3: https://github.com/dotnet/SqlClient/blob/main/CHANGELOG.md
- 4: https://github.com/dotnet/sqlclient/releases
- 5: https://techcommunity.microsoft.com/blog/sqlserver/released-microsoft-data-sqlclient-6-0-preview-1/4231002
- 6: https://www.nuget.org/packages/microsoft.data.sqlclient
- 7: https://learn.microsoft.com/en-us/answers/questions/1055145/replacing-system-data-sqlclient-with-microsoft-dat
- 8: https://learn.microsoft.com/en-us/answers/questions/1657303/compatibility-issues-with-sqlclient-libraries-afte
- 9: https://learn.microsoft.com/en-us/answers/questions/986331/data-sqlclient

Major Breaking Changes in Microsoft.Data.SqlClient 6.0.1 Confirmed

The web query confirms that the upgrade from version 5.2.2 to 6.0.1 introduces several breaking changes that require careful review:

  • Dropped Platform Support:

    • Eliminates support for .NET Standard.
    • No support for .NET Framework versions below 4.6.2.
    • Removes Universal Windows Platform (UWP) references.
    • Discontinues SQL Server 2000 client-side debugging.
  • Authentication Modifications:

    • Active Directory Managed Identity now requires ClientId instead of ObjectId.
  • Connection Behavior Changes:

    • The Encrypt connection string property now defaults to true.
    • SqlBulkCopy behavior changes by using RowsCopied64 for large operations.

Please ensure these changes are compatible with your application’s framework and usage patterns, updating any affected configuration or connection strings accordingly.

src/backend/Functions/Ts.Functions/Ts.Functions.csproj (1)

29-29: Reconsider adding System.Private.Uri package reference

System.Private.Uri is an implementation detail of the .NET Core runtime and shouldn't be referenced directly. The public API surface for URI manipulation is available in System.Uri class within System.Runtime.

Please clarify why this package is needed. If you're encountering URI-related issues, consider using the public API surface instead.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2025

@mikmog mikmog merged commit 772a17e into main Feb 9, 2025
8 of 9 checks passed
@mikmog mikmog deleted the up-nugets-backend branch February 9, 2025 16:17
This was referenced Mar 2, 2025
@coderabbitai coderabbitai bot mentioned this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants