Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oauth not working in windows binaries #75

Closed
ghost opened this issue Feb 10, 2018 · 2 comments
Closed

Oauth not working in windows binaries #75

ghost opened this issue Feb 10, 2018 · 2 comments

Comments

@ghost
Copy link

ghost commented Feb 10, 2018

gallery-dl oauth:flickr --verbose
[gallery-dl][debug] Version 1.1.2
[gallery-dl][debug] Python 3.4.4 - Windows-10-10.0.16299
[gallery-dl][debug] requests 2.18.4
[gallery-dl][debug] urllib3 1.22
[gallery-dl][debug] Starting DownloadJob for 'oauth:flickr'
[oauth][debug] Using OAuthFlickr for 'oauth:flickr'
[oauth][error] An unexpected error occurred: TypeError - urlencode() got an unexpected keyword argument 'quote_via'. Please run gallery-dl again with the --verbose flag, copy its output and report this issue on https://github.com/mikf/gallery-dl/issues .
[oauth][debug] Traceback
Traceback (most recent call last):
  File "E:\gallery-dl\gallery_dl\job.py", line 59, in run
  File "E:\gallery-dl\gallery_dl\extractor\oauth.py", line 184, in items
  File "E:\gallery-dl\gallery_dl\extractor\oauth.py", line 81, in _oauth1_authorization_flow
  File "E:\gallery-dl\gallery_dl\util.py", line 489, in get
  File "E:\gallery-dl\gallery_dl\util.py", line 494, in sign
TypeError: urlencode() got an unexpected keyword argument 'quote_via'

Works fine when I install via pip (python 3.6.4)

@mikf
Copy link
Owner

mikf commented Feb 10, 2018

Thanks for reporting this.

Windows binaries use Python 3.4 and the quote_via argument for urlencode(), which the error message is referring to, got first introduced in Python 3.5.

@mikf mikf closed this as completed in 6577326 Feb 10, 2018
@Hrxn
Copy link
Contributor

Hrxn commented Feb 11, 2018

Damn... I haven't used the prebaked Windows binaries in quite a while, only my system Python and the pip package or the source archive. Otherwise I would have noticed this before as well..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants