Check the AVAsset's type before casting to an AVURLAsset

Author: ejensen

AsyncDisplayKit/ASVideoNode.mm

@@ -277,7 +277,10 @@ - (void)setAsset:(AVAsset *)asset
 {
   ASDN::MutexLocker l(_videoLock);
 
-  if (ASObjectIsEqual(((AVURLAsset *)asset).URL, ((AVURLAsset *)_asset).URL)) {
+  if (ASObjectIsEqual(asset, _asset)
+    || ([asset isKindOfClass:[AVURLAsset class]]
+      && [_asset isKindOfClass:[AVURLAsset class]]
+      && ASObjectIsEqual(((AVURLAsset *)asset).URL, ((AVURLAsset *)_asset).URL))) {
     return;
   }
 

AsyncDisplayKitTests/ASVideoNodeTests.m

@@ -13,7 +13,7 @@
 @interface ASVideoNodeTests : XCTestCase
 {
   ASVideoNode *_videoNode;
-  AVAsset *_firstAsset;
+  AVURLAsset *_firstAsset;
   AVAsset *_secondAsset;
 }
 @end
@@ -43,7 +43,7 @@ @implementation ASVideoNodeTests
 - (void)setUp
 {
   _videoNode = [[ASVideoNode alloc] init];
-  _firstAsset = [AVAsset assetWithURL:[NSURL URLWithString:@"firstURL"]];
+  _firstAsset = [AVURLAsset assetWithURL:[NSURL URLWithString:@"firstURL"]];
   _secondAsset = [AVAsset assetWithURL:[NSURL URLWithString:@"secondURL"]];
 }
 
@@ -67,7 +67,7 @@ - (void)testVideoNodeDoesNotReplaceAVPlayerItemWhenSameURLIsSet
   _videoNode.asset = _firstAsset;
   AVPlayerItem *item = [_videoNode currentItem];
 
-  _videoNode.asset = _firstAsset;
+  _videoNode.asset = [AVAsset assetWithURL:_firstAsset.URL];
   AVPlayerItem *secondItem = [_videoNode currentItem];
 
   XCTAssertEqualObjects(item, secondItem);