extended window bindings with a way to leave fullscreen / kiosk mode #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. Thanks for this. |
miketheprogrammer
added a commit
that referenced
this pull request
Nov 7, 2015
extended window bindings with a way to leave fullscreen / kiosk mode
|
Thanks for the great bindings! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
window.Fullscreen()makes it impossible to gracefully leave the fullscreen / kiosk mode without manually executing commands on the window itself.This PR fixes it by extending both methods with a bool
window.Fullscreen(fullscreen bool)andwindow.Kiosk(kiosk bool)to set / unset the mode.