Skip to content

Commit 553591b

Browse files
authored
Fix to window title and expected behavior of "HasFrame"
Fix to window title and expected behavior of "HasFrame" 1. Correction to Title to utilize the option.Title instead of spawn.ApplicationName (was incorrectly ignoring the options Title) 2. "HasFrame" expected behavior fix: 'true' for having a frame and 'false' for not having a frame.
1 parent 92e66a5 commit 553591b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

lib/bindings/window/window.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,9 @@ func NewWindow(options Options) *Window {
7474
ObjectType: "window",
7575
Args: CommandArguments{
7676
RootUrl: w.Url,
77-
Title: spawn.ApplicationName,
77+
Title: options.Title, // Should be using the options.Title, not spawn.ApplicationName
7878
Size: size,
79-
HasFrame: !options.HasFrame,
79+
HasFrame: options.HasFrame, // This was reversed, HasFrame behavior should be 'true' (has frame) and 'false' (no frame)
8080
IconPath: options.IconPath,
8181
},
8282
}

0 commit comments

Comments
 (0)