From 330bb8790f71fb4e2ba8093a41c3de2d29767cbf Mon Sep 17 00:00:00 2001 From: Antonino Maniscalco Date: Mon, 11 Nov 2024 19:06:33 +0100 Subject: [PATCH] Remove code incorrectly flagging msm events All msm events that started with `msm_gpu_submit` where incorrectly being flagged as `TRACE_FLAG_SW_QUEUE`. Remove this code since events are tagged anyway elsewhere. This fixes the graph tooltip incorrectly reporting SW queue duration three times. --- src/trace-cmd/trace-read.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/trace-cmd/trace-read.cpp b/src/trace-cmd/trace-read.cpp index 96deba0e..41fb56d9 100644 --- a/src/trace-cmd/trace-read.cpp +++ b/src/trace-cmd/trace-read.cpp @@ -1677,8 +1677,6 @@ static void init_event_flags( trace_data_t &trace_data, trace_event_t &event ) event.flags |= TRACE_FLAG_FENCE_SIGNALED; else if ( strstr( event.name, "amdgpu_cs_ioctl" ) ) event.flags |= TRACE_FLAG_SW_QUEUE; - else if ( strstr( event.name, "msm_gpu_submit" ) ) - event.flags |= TRACE_FLAG_SW_QUEUE; else if ( strstr( event.name, "amdgpu_sched_run_job" ) ) event.flags |= TRACE_FLAG_HW_QUEUE; }