feat: update all blueprints to encourage non-duplicate test names

mike-north · Jul 30, 2018 · 598adcf · 598adcf
1 parent 2fff67d
commit 598adcf
Show file tree

Hide file tree

Showing 10 changed files with 17 additions and 26 deletions.
diff --git a/blueprints/acceptance-test/qunit-rfc-232-files/tests/acceptance/__name__-test.__ext__ b/blueprints/acceptance-test/qunit-rfc-232-files/tests/acceptance/__name__-test.__ext__
@@ -5,8 +5,7 @@ import { EmberApplicationTest } from 'ember-qunit-decorators/test-support';
 @suite('<%= friendlyTestName %>')
 export class <%= testClassName %>AcceptanceTest extends EmberApplicationTest {
 
-  @test('visiting /<%= dasherizedModuleName %>')
-  async visitPage(assert<% if (isTyped) {%>: Assert<% } %>) {
+  @test async 'visiting /<%= dasherizedModuleName %>'(assert<% if (isTyped) {%>: Assert<% } %>) {
     await visit('/<%= dasherizedModuleName %>');
     assert.equal(currentURL(), '/<%= dasherizedModuleName %>');
   }

diff --git a/...prints/component-test/qunit-rfc-232-files/__root__/__testType__/__path__/__test__.__ext__ b/...prints/component-test/qunit-rfc-232-files/__root__/__testType__/__path__/__test__.__ext__
@@ -6,18 +6,16 @@ import hbs from 'htmlbars-inline-precompile';
 @suite('<%= friendlyTestDescription %>')
 export class <%= testClassName %>ComponentTest extends EmberRenderingTest {
 
-  @test('it renders when used in {{inline-form}}')
-  async testInline(assert<% if (isTyped) {%>: Assert<% } %>) {
+  @test async 'it renders when used in {{inline-form}}'(assert<% if (isTyped) {%>: Assert<% } %>) {
     // Set any properties with this.set('myProperty', 'value');
     // Handle any actions with this.set('myAction', function(val) { ... });
 
     await render(hbs`{{<%= componentPathName %>}}`);
 
     assert.equal(('' + this.element.textContent).trim(), '');
   }
-  @test('it renders when used in {{#block-form}}  {{/block-form}}')
 
-  async testBlock(assert<% if (isTyped) {%>: Assert<% } %>) {
+  @test async 'it renders when used in {{#block-form}}  {{/block-form}}'(assert<% if (isTyped) {%>: Assert<% } %>) {
     // Template block usage:
     await render(hbs`
       {{#<%= componentPathName %>}}
@@ -33,8 +31,7 @@ export class <%= testClassName %>ComponentTest extends EmberRenderingTest {
 @suite('<%= friendlyTestDescription %>')
 export class <%= testClassName %> extends EmberTest {
 
-  @test('it exists')
-  itExists(assert<% if (isTyped) {%>: Assert<% } %>) {
+  @test 'it exists'(assert<% if (isTyped) {%>: Assert<% } %>) {
     let component = this.owner.factoryFor('component:<%= componentPathName %>').create();
     assert.ok(component);
   }

diff --git a/blueprints/controller-test/qunit-rfc-232-files/tests/unit/__path__/__test__.__ext__ b/blueprints/controller-test/qunit-rfc-232-files/tests/unit/__path__/__test__.__ext__
@@ -3,9 +3,9 @@ import { EmberTest } from 'ember-qunit-decorators/test-support';
 
 @suite('<%= friendlyTestDescription %>')
 export class <%= testClassName %>ControllerTest extends EmberTest {
+
   // Replace this with your real tests.
-  @test('it exists')
-  itExists(assert<% if (isTyped) {%>: Assert<% } %>) {
+  @test 'it exists'(assert<% if (isTyped) {%>: Assert<% } %>) {
     let controller = this.owner.lookup('controller:<%= controllerPathName %>');
     assert.ok(controller);
   }

diff --git a/blueprints/helper-test/qunit-rfc-232-files/tests/__testType__/helpers/__name__-test.__ext__ b/blueprints/helper-test/qunit-rfc-232-files/tests/__testType__/helpers/__name__-test.__ext__
@@ -6,8 +6,7 @@ import hbs from 'htmlbars-inline-precompile';
 @suite('<%= friendlyTestName %>')
 export class <%= testClassName %>HelperTest extends EmberRenderingTest {
   // Replace this with your real tests.
-  @test('it renders')
-  async itRenders(assert<% if (isTyped) {%>: Assert<% } %>) {
+  @test async 'it renders'(assert<% if (isTyped) {%>: Assert<% } %>) {
     this.set('inputValue', '1234');
 
     await render(hbs`{{<%= dasherizedModuleName %> inputValue}}`);
@@ -20,8 +19,7 @@ import { <%= camelizedModuleName %> } from '<%= dasherizedModulePrefix %>/helper
 @suite('<%= friendlyTestName %>')
 export class <%= testClassName %>HelperTest extends EmberTest {
   // Replace this with your real tests.
-  @test('it works')
-  itWorks(assert<% if (isTyped) {%>: Assert<% } %>) {
+  @test 'it works'(assert<% if (isTyped) {%>: Assert<% } %>) {
     let result = <%= camelizedModuleName %>([42]);
     assert.ok(result);
   }

diff --git a/...prints/initializer-test/qunit-rfc-232-files/tests/unit/initializers/__name__-test.__ext__ b/...prints/initializer-test/qunit-rfc-232-files/tests/unit/initializers/__name__-test.__ext__
@@ -25,8 +25,7 @@ export class <%= testClassName %>InitializerTest extends EmberTest {
   }
 
   // Replace this with your real tests.
-  @test('it works')
-  async itWorks(assert<% if (isTyped) {%>: Assert<% } %>) {
+  @test async 'it works'(assert<% if (isTyped) {%>: Assert<% } %>) {
     await this.application.boot();
 
     assert.ok(true);

diff --git a/...itializer-test/qunit-rfc-232-files/tests/unit/instance-initializers/__name__-test.__ext__ b/...itializer-test/qunit-rfc-232-files/tests/unit/instance-initializers/__name__-test.__ext__
@@ -28,8 +28,7 @@ export class <%= testClassName %>InstanceInitializerTest extends EmberTest {
   }
 
   // Replace this with your real tests.
-  @test('it works')
-  async itWorks(assert<% if (isTyped) {%>: Assert<% } %>) {
+  @test async 'it works'(assert<% if (isTyped) {%>: Assert<% } %>) {
     await this.instance.boot();
 
     assert.ok(true);

diff --git a/blueprints/mixin-test/qunit-rfc-232-files/tests/unit/mixins/__name__-test.__ext__ b/blueprints/mixin-test/qunit-rfc-232-files/tests/unit/mixins/__name__-test.__ext__
@@ -4,9 +4,9 @@ import { suite, test } from 'qunit-decorators';
 
 @suite('<%= friendlyTestName %>')
 export class <%= testClassName %>MixinTest {
+
   // Replace this with your real tests.
-  @test('it works')
-  itExists(assert<% if (isTyped) {%>: Assert<% } %>) {
+  @test 'it works'(assert<% if (isTyped) {%>: Assert<% } %>) {
     let <%= classifiedModuleName %>Object = EmberObject.extend(<%= classifiedModuleName %>Mixin);
     let subject = <%= classifiedModuleName %>Object.create();
     assert.ok(subject);

diff --git a/blueprints/route-test/qunit-rfc-232-files/tests/unit/__path__/__test__.__ext__ b/blueprints/route-test/qunit-rfc-232-files/tests/unit/__path__/__test__.__ext__
@@ -4,8 +4,7 @@ import { EmberTest } from 'ember-qunit-decorators/test-support';
 @suite('<%= friendlyTestDescription %>')
 export class <%= testClassName %>RouteTest extends EmberTest {
 
-  @test('it exists')
-  itExists(assert<% if (isTyped) {%>: Assert<% } %>) {
+  @test 'it exists'(assert<% if (isTyped) {%>: Assert<% } %>) {
     let route = this.owner.lookup('route:<%= moduleName %>');
     assert.ok(route);
   }

diff --git a/blueprints/service-test/qunit-rfc-232-files/__root__/__testType__/__path__/__test__.__ext__ b/blueprints/service-test/qunit-rfc-232-files/__root__/__testType__/__path__/__test__.__ext__
@@ -3,9 +3,9 @@ import { EmberTest } from 'ember-qunit-decorators/test-support';
 
 @suite('<%= friendlyTestDescription %>')
 export class <%= testClassName %>ServiceTest extends EmberTest {
+
   // Replace this with your real tests.
-  @test('it exists')
-  itExists(assert<% if (isTyped) {%>: Assert<% } %>) {
+  @test 'it exists'(assert<% if (isTyped) {%>: Assert<% } %>) {
     let service = this.owner.lookup('service:<%= dasherizedModuleName %>');
     assert.ok(service);
   }

diff --git a/blueprints/util-test/qunit-rfc-232-files/tests/unit/utils/__name__-test.__ext__ b/blueprints/util-test/qunit-rfc-232-files/tests/unit/utils/__name__-test.__ext__
@@ -3,9 +3,9 @@ import { suite, test } from 'qunit-decorators';
 
 @suite('<%= friendlyTestName %>')
 export class <%= testClassName %>Test {
+
   // Replace this with your real tests.
-  @test('it works')
-  itWorks(assert<% if (isTyped) {%>: Assert<% } %>) {
+  @test 'it works'(assert<% if (isTyped) {%>: Assert<% } %>) {
     let result = <%= camelizedModuleName %>();
     assert.ok(result);
   }