Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics not returning correct data #27

Closed
jfitch11 opened this issue Nov 3, 2023 · 3 comments
Closed

Metrics not returning correct data #27

jfitch11 opened this issue Nov 3, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@jfitch11
Copy link

jfitch11 commented Nov 3, 2023

Describe the bug
I've got two fresh deployments of dorametrix (following the documented setup guide) each with a few days old change events and deployment events in the DynamoDB table and the metrics endpoint is always returning 0 changes and 0 deployments for this and other repos. The last deployment endpoint does return the correct data and I've had no issues with POSTing data to dorametrix. Is there something I might be missing in my deployments? I've tried both getting data from two different dates and with the sliding window set. I do see the cached item added to the table after the request.

Anything I'm missing (or more details needed) or is this a known issue?

@jfitch11
Copy link
Author

We believe the issue is here

KeyConditionExpression: 'pk = :pk AND sk = :sk',
where it ends up checking date = date instead of a range of dates. Is that a bug or something intentional and we're missing something?

@mikaelvesavuori
Copy link
Owner

Hi @jfitch11! Something seems to be up with GitHub notifications so I completely missed the issue. Will look into this soon.

@mikaelvesavuori
Copy link
Owner

mikaelvesavuori commented Nov 20, 2023

Hey again @jfitch11. Your assessment was correct. For the life of me, I can't understand how I let that bug creep in... But now it's solved. The solution was to use >= for the sk.

The solution is pushed, together with some other (minor) fixes, in 3.0.1. Please see https://github.com/mikaelvesavuori/dorametrix/releases/tag/v3.0.1 for more.

@mikaelvesavuori mikaelvesavuori added the bug Something isn't working label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants