Automagically Bind notify Methods
#306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automagically bind `notify` methods on all wrapper classes so the notify method can be destructured within the import statement and not run into any `this` related errors.
mikaelbr
approved these changes
Feb 17, 2020
Owner
mikaelbr
left a comment
mikaelbr
left a comment
There was a problem hiding this comment.
Oh! Missed this one! Thanks for submitting it. I get this can be frustrating when doing destructuring for instance. I think it looks fine. Could you remove package-lock.json from the commit also?
Revert the changes made to `package-lock.json` in the commit 789c544.
Owner
|
Thanks! |
|
How is this breaking? 🤔 |
Owner
|
Strictly not very breaking. The most notable breaking I found was sanitizing timeout on snoretoast handling (see changelog https://github.com/mikaelbr/node-notifier/blob/master/CHANGELOG.md#breaking-changes). But I also marked this as breaking in the changelog as it, in theory, does break from existing API. |
|
Thanks |
This was referenced Mar 7, 2021
Closed
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automagically bind
notifymethods on all wrapper classes so the notify method can be destructured within the import statement and not run into anythisrelated errors.