From 35180f1a1cd4bbdc1b0b6415cfe1c6f234d2f607 Mon Sep 17 00:00:00 2001 From: "Shahar \"Dawn\" Or" Date: Sun, 13 Oct 2024 09:14:51 +0700 Subject: [PATCH] feat: rm no-redeclare closes #1514 --- src/_intentionally-unused-rules.ts | 4 ++++ src/rules.ts | 1 - src/test/_expected-exported-value.ts | 2 -- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/_intentionally-unused-rules.ts b/src/_intentionally-unused-rules.ts index faff02b7..0cba3483 100644 --- a/src/_intentionally-unused-rules.ts +++ b/src/_intentionally-unused-rules.ts @@ -34,6 +34,10 @@ export const intentionallyUnusedRules: string[] = [ // Covered by strict TypeScript '@typescript-eslint/no-invalid-this', + // Covered by TypeScript + 'no-redeclare', + '@typescript-eslint/no-redeclare', + // ## Project specific '@typescript-eslint/no-restricted-imports', diff --git a/src/rules.ts b/src/rules.ts index dca575f0..b5fbbadc 100644 --- a/src/rules.ts +++ b/src/rules.ts @@ -157,7 +157,6 @@ export const tseslintRules: Record = { '@typescript-eslint/no-non-null-asserted-nullish-coalescing': ['error'], '@typescript-eslint/no-non-null-asserted-optional-chain': ['error'], '@typescript-eslint/no-non-null-assertion': ['error'], - '@typescript-eslint/no-redeclare': ['error', { builtinGlobals: false }], '@typescript-eslint/no-redundant-type-constituents': ['error'], '@typescript-eslint/no-require-imports': [ 'error', diff --git a/src/test/_expected-exported-value.ts b/src/test/_expected-exported-value.ts index aa52b87b..5b70221b 100644 --- a/src/test/_expected-exported-value.ts +++ b/src/test/_expected-exported-value.ts @@ -83,7 +83,6 @@ export const expectedEslintRules: Record< 'no-octal-escape': ['error'], 'no-proto': ['error'], 'no-prototype-builtins': ['error'], - 'no-redeclare': ['off'], 'no-regex-spaces': ['error'], 'no-return-assign': ['error', 'except-parens'], 'no-self-assign': ['error', { props: true }], @@ -328,7 +327,6 @@ export const expectedTseslintRules: Record< '@typescript-eslint/no-non-null-asserted-nullish-coalescing': ['error'], '@typescript-eslint/no-non-null-asserted-optional-chain': ['error'], '@typescript-eslint/no-non-null-assertion': ['error'], - '@typescript-eslint/no-redeclare': ['error', { builtinGlobals: false }], '@typescript-eslint/no-redundant-type-constituents': ['error'], '@typescript-eslint/no-require-imports': [ 'error',