Do not assume that subdirectories of temporary and data directories exist

Author: Jamie Snape

core/controllers/components/UtilityComponent.php

@@ -344,25 +344,32 @@ public static function run_sql_from_file($db, $sqlfile)
     public static function getDataDirectory($subdir = '')
     {
         $settingModel = MidasLoader::loadModel('Setting');
+
         try {
             $dataDirectory = $settingModel->getValueByName('data_directory');
         } catch (Exception $e) {
             $dataDirectory = null;
         }
+
         if (!isset($dataDirectory) || empty($dataDirectory)) {
             if (getenv('midas_data_path') !== false) {
                 $dataDirectory = getenv('midas_data_path');
             } else {
                 $dataDirectory = BASE_PATH.'/data';
             }
         }
+
         if ($subdir == '') {
-            $dataDirectory .= '/';
+            $path = $dataDirectory.'/';
         } else {
-            $dataDirectory .= '/'.$subdir.'/';
+            $path = $dataDirectory.'/'.$subdir.'/';
+        }
+
+        if (is_writable($dataDirectory) && !file_exists($path)) {
+            mkdir($path, 0777, true);
         }
 
-        return $dataDirectory;
+        return realpath($path);
     }
 
     /**
@@ -374,13 +381,15 @@ public static function getDataDirectory($subdir = '')
     public static function getTempDirectory($subdir = "misc")
     {
         $settingModel = MidasLoader::loadModel('Setting');
+
         try {
             $tempDirectory = $settingModel->getValueByName('temp_directory');
         } catch (Exception $e) {
             // if the setting model hasn't been installed, or there is no
             // value in the settings table for this, provide a default
             $tempDirectory = null;
         }
+
         if (!isset($tempDirectory) || empty($tempDirectory)) {
             if (getenv('midas_temp_path') !== false) {
                 $tempDirectory = getenv('midas_temp_path');
@@ -389,7 +398,13 @@ public static function getTempDirectory($subdir = "misc")
             }
         }
 
-        return $tempDirectory.'/'.$subdir;
+        $path = $tempDirectory.'/'.$subdir;
+
+        if (is_writable($tempDirectory) && !file_exists($path)) {
+            mkdir($path, 0777, true);
+        }
+
+        return realpath($path);
     }
 
     /**

data/assetstore/.gitignore renamed to data/.gitignore

@@ -1 +1,3 @@
-pvw-data
+*
+!.gitignore
+!.htaccess