Skip to content
This repository was archived by the owner on Sep 10, 2021. It is now read-only.

Commit 3a6d059

Browse files
author
Jamie Snape
committed
Remove ob_end_clean() sledgehammer
This kills PHPUnit 3.6 and above and I the root cause of the behavior that it cures was fixed in 4a6b62c.
1 parent 3661f98 commit 3a6d059

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

core/controllers/DownloadController.php

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -173,10 +173,6 @@ public function indexAction()
173173
}
174174
else
175175
{
176-
while(ob_get_level() > 0)
177-
{
178-
ob_end_clean();
179-
}
180176
ob_start();
181177
Zend_Loader::loadClass('ZipStream', BASE_PATH.'/library/ZipStream/');
182178
$this->_helper->viewRenderer->setNoRender();
@@ -227,10 +223,6 @@ public function indexAction()
227223
}
228224

229225
session_write_close(); //unlock session writing for concurrent access
230-
while(ob_get_level() > 0)
231-
{
232-
ob_end_clean();
233-
}
234226
ob_start();
235227
$zip = new ZipStream($name.'.zip');
236228
UtilityComponent::disableMemoryLimit();
@@ -521,10 +513,6 @@ public function appletAction()
521513
*/
522514
private function _downloadEmptyItem($item)
523515
{
524-
while(ob_get_level() > 0)
525-
{
526-
ob_end_clean();
527-
}
528516
ob_start();
529517
Zend_Loader::loadClass('ZipStream', BASE_PATH.'/library/ZipStream/');
530518
$this->disableView();

0 commit comments

Comments
 (0)