1.24.0 Release (#1884)

* Update New-MgTeamTagMember.md

Fixed Example 1 (line 45)

* Added a second example

* Open api updates and module version update

* Added AllowClober parameter to overwrite the existing old modules

* Changed expected param sets to 3 on the connect-mggraph pester test

* Conformed test results as per previous pipeline output

* Returned parameter set count to 3

* Commented out null values

* Rolled back

* Update projectsbot.yml

* Remove unsupported path in WindowsUpdates.

* Remove create PR GitHub actions. (#1866)

* Set default value for BaseBranch.

* Set default value for BaseBranch for help docs.

* Remove unnecessary KeyVault task.

* Update create PR task.

* Upgrade AzDo compliance tasks.

* Update cred scan.

* Set msBuildArchitecture to x64

* Weekly OpenAPI Docs Refresh (#1877)

* Weekly OpenApiDocs Download.

* Add generated MgCommandMetadata.json. [run ci]

---------

Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com>

* Add BinSkim.

* Upgrade cred scan version.

* Remove generate-helpdocs-template from normal builds.

* Update AzDo Pipelines (#1881)

* Remove unnecessary KeyVault task.

* Update create PR task.

* Upgrade AzDo compliance tasks.

* Update cred scan.

* Set msBuildArchitecture to x64

* Add BinSkim.

* Upgrade cred scan version.

* Remove generate-helpdocs-template from normal builds.

* Remove duplicate AzDo task.

---------

Co-authored-by: Yuriy Samorodov <Yuriy.Samorodov@gmail.com>
Co-authored-by: Tim <timwamalwa@gmail.com>
Co-authored-by: Eunice Waweru <73849846+msewaweru@users.noreply.github.com>
Co-authored-by: DeVere Dyett <ddyett@microsoft.com>
Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com>

Author: 6 people

.azure-pipelines/common-templates/checkout.yml

@@ -33,8 +33,9 @@ steps:
         git pull
         git status
 
-
-  - task: securedevelopmentteam.vss-secure-development-tools.build-task-credscan.CredScan@2
-    displayName: "Run CredScan"
+  - task: securedevelopmentteam.vss-secure-development-tools.build-task-credscan.CredScan@3
+    displayName: 'Run CredScan - Src'
     inputs:
-      debugMode: false
+      debugMode: false
+      scanFolder: '$(Build.SourcesDirectory)\src'
+      toolMajorVersion: 'V2'

.azure-pipelines/common-templates/security-postchecks-template.yml

@@ -1,9 +1,7 @@
 # Copyright (c) Microsoft Corporation. All rights reserved.
 # Licensed under the MIT License.
 steps:
-- task: CodesignValidation@0
-
-- task: SdtReport@1
+- task: SdtReport@2
   displayName: "Security Analysis Report"
   continueOnError: true
   condition: succeededOrFailed()

.azure-pipelines/common-templates/security-prechecks-template.yml

@@ -1,15 +1,14 @@
 # Copyright (c) Microsoft Corporation. All rights reserved.
 # Licensed under the MIT License.
 steps:
-- task: CredScan@2
-  displayName: 'Run CredScan'
+- task: securedevelopmentteam.vss-secure-development-tools.build-task-credscan.CredScan@3
+  displayName: 'Run CredScan - Src'
   inputs:
     debugMode: false
-    batchSize: 20
+    scanFolder: '$(Build.SourcesDirectory)\src'
     toolMajorVersion: 'V2'
-    searchersFileType: 'Skype'
 
-- task: PoliCheck@1
+- task: PoliCheck@2
   displayName: 'Run PoliCheck'
   condition: and(succeeded(), eq(eq(variables['Build.SourceBranch'], 'refs/heads/main'), false))
   inputs:

.azure-pipelines/generate-auth-module-template.yml

@@ -21,14 +21,6 @@ parameters:
     displayName: 'Build Number'
     type: string
     default: $[format('{0:yyMMddHH}', pipeline.startTime)]
-  - name: AZURESUBSCRIPTION
-    default: "Microsoft Graph Build Agents (Win+Lin)"
-    displayName: Azure Subscription
-
-  - name: KEYVAULT
-    default: "msgraph-build-keyvault"
-    displayName: Build Key vault
-
 
 jobs:
 - job: MsGraphPSSDKAuthModuleGeneration
@@ -37,13 +29,6 @@ jobs:
   steps:
   - template: ./common-templates/install-tools-template.yml
 
-  - task: AzureKeyVault@1
-    inputs:
-     azureSubscription: $(AZURESUBSCRIPTION)
-     KeyVaultName: $(KEYVAULT)
-     SecretsFilter: '*'
-     RunAsPreJob: true
-
   - task: PowerShell@2
     displayName: 'Generate and Build Auth Module'
     env:
@@ -63,19 +48,6 @@ jobs:
       projects: '$(System.DefaultWorkingDirectory)/src/Authentication/Authentication.Test/*.csproj'
       testRunTitle: 'Run Enabled Tests'
 
-  - task: RoslynAnalyzers@2
-    inputs:
-        userProvideBuildInfo: 'msBuildInfo'
-        msBuildVersion: '16.0'
-        msBuildArchitecture: 'DotNetCore'
-        msBuildCommandline: '"C:\Program Files\dotnet\dotnet.exe" msbuild $(System.DefaultWorkingDirectory)//src//Authentication//Authentication.sln /nologo /nr:false'
-
-  - task: CodeMetrics@1
-    displayName: 'Run CodeMetrics'
-    inputs:
-        Files: '$(System.DefaultWorkingDirectory)//**//Microsoft.Graph.Authentication.dll;$(System.DefaultWorkingDirectory)//**//Microsoft.Graph.Authentication.exe'
-        continueOnError: true
-
   - task: PowerShell@2
     displayName: 'Generate and Build Auth Module'
     inputs:

.azure-pipelines/generate-modules-template.yml

@@ -152,8 +152,6 @@ jobs:
       script: |
         . $(System.DefaultWorkingDirectory)/tools/PostGeneration/FindDuplicateCommand.ps1 -SourcePath "$(System.DefaultWorkingDirectory)/src/"
 
-  - template: ./generation-templates/generate-helpdocs-template.yml
-
   - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@1
     displayName: 'ESRP DLL Strong Name (Graph Resource Modules)'
     enabled: true

.azure-pipelines/generation-templates/generate-helpdocs-template.yml

@@ -2,6 +2,9 @@
 # Licensed under the MIT License.
 
 parameters:
+  - name: BaseBranch
+    type: string
+    default: "dev"
   - name: DOCSBRANCH
     type: string
     default: "DocsGeneration"
@@ -54,4 +57,17 @@ steps:
     script: |
       git status
       git push --set-upstream "https://$(GITHUB_TOKEN)@github.com/microsoftgraph/msgraph-sdk-powershell.git" $(ComputeBranch.DocsBranch)
-      git status
+      git status
+
+- task: PowerShell@2
+  displayName: Create Pull Request for Weekly Help Docs Generation
+  env:
+    GITHUB_TOKEN: $(GITHUB_TOKEN)
+  inputs:
+    pwsh: true
+    targetType: inline
+    script: |
+      $Title = "[v1] Weekly Help Docs Generation"
+      $Body = "This pull request was automatically created by Azure Pipelines. **Important** Check for unexpected deletions or changes in this PR."
+      $BaseBranch = "${{ parameters.BaseBranch }}"
+      . $(System.DefaultWorkingDirectory)/scripts/create-pull-request.ps1 -Title $Title -Body $Body -BaseBranchName $BaseBranch

.azure-pipelines/generation-templates/generate-service-modules.yml

@@ -25,9 +25,15 @@ parameters:
   - name: GenerateHelpDocs
     type: boolean
     default: false
+  - name: GeneratePullRequest
+    type: boolean
+    default: false
   - name: DOCSBRANCH
     type: string
     default: "DocsGeneration"
+  - name: BaseBranchName
+    type: string
+    default: "dev"
 
 jobs:
   - job: GenerateServiceModules
@@ -44,7 +50,9 @@ jobs:
       PublishToFeed: ${{ parameters.PublishToFeed }}
       GenerateCommandMetadata: ${{ parameters.GenerateCommandMetadata }}
       GenerateHelpDocs: ${{ parameters.GenerateHelpDocs }}
+      GeneratePullRequest: ${{ parameters.GeneratePullRequest }}
       DocsBranch: ${{ parameters.DocsBranch }}
+      BaseBranchName: ${{ parameters.BaseBranchName }}
     steps:
       - template: ../common-templates/checkout.yml
         parameters:
@@ -155,6 +163,21 @@ jobs:
       - ${{ if eq(parameters.GenerateCommandMetadata, true) }}:
         - template: ./generate-command-metadata-template.yml
 
+      - ${{ if eq(parameters.GeneratePullRequest, true) }}:
+        - task: PowerShell@2
+          displayName: Create Pull Request for generated build
+          env:
+            GITHUB_TOKEN: $(GITHUB_TOKEN)
+          inputs:
+            pwsh: true
+            targetType: inline
+            script: |
+              $Title = "[v1] Weekly OpenApiDocs Refresh"
+              $Body = "This pull request was automatically created by Azure Pipelines. **Important** Check for unexpected deletions or changes in this PR."
+              $BaseBranch = "${{ parameters.BaseBranchName }}"
+              Write-Host "Executing . $(System.DefaultWorkingDirectory)/scripts/create-pull-request.ps1 -Title $Title -Body $Body -BaseBranchName $BaseBranch"
+              . $(System.DefaultWorkingDirectory)/scripts/create-pull-request.ps1 -Title $Title -Body $Body -BaseBranchName $BaseBranch
+
       - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@1
         displayName: ESRP DLL strong name (Service Modules)
         condition: and(succeeded(), eq('${{ parameters.EnableSigning }}', true))
@@ -290,8 +313,9 @@ jobs:
       - ${{ if eq(parameters.GenerateHelpDocs, true) }}:
         - template: ./generate-helpdocs-template.yml
           parameters:
-              DOCSBRANCH: $(DocsBranch)
-              ModulesToGenerate: $(ModulesToGenerate)
+            BaseBranch: $(BaseBranchName)
+            DOCSBRANCH: $(DocsBranch)
+            ModulesToGenerate: $(ModulesToGenerate)
 
       - task: PowerShell@2
         displayName: Find Duplicate Commands

.azure-pipelines/integrated-pipeline.yml

@@ -6,14 +6,6 @@ parameters:
     default: 1es-windows-ps-compute
     displayName: Build Agent
 
-  - name: AzureSubscription
-    default: "Microsoft Graph Build Agents (Win+Lin)"
-    displayName: Azure Subscription
-
-  - name: KeyVault
-    default: "msgraph-build-keyvault"
-    displayName: Build Key vault
-
 variables:
   AUTH_MODULE_NAME: 'Authentication'
   AUTH_MODULE_PATH: 'src\Authentication\Authentication'
@@ -29,8 +21,6 @@ variables:
   GitUserName: 'Microsoft Graph DevX Tooling'
   BUILDNUMBER: -1
   BUILDAGENT: ${{ parameters.BuildAgent }}
-  AZURESUBSCRIPTION: ${{ parameters.AzureSubscription }}
-  KEYVAULT: ${{ parameters.KeyVault }}
 
 pool: $(BUILDAGENT)
 
@@ -72,18 +62,6 @@ stages:
             Write-Host $(BUILDNUMBER)
             printenv
 
-- stage: GetSecrets
-  displayName: 'Get Secrets From Azure KeyVault'
-  jobs:
-  - job: GetSecrets
-    steps:
-    - task: AzureKeyVault@1
-      inputs:
-        azureSubscription: $(AZURESUBSCRIPTION)
-        KeyVaultName: $(KEYVAULT)
-        SecretsFilter: '*'
-        RunAsPreJob: true
-
 - stage: SecurityPreChecks
   displayName: 'Security Pre Checks'
   jobs:
@@ -102,8 +80,6 @@ stages:
       AUTH_MODULE_PATH: $(AUTH_MODULE_PATH)
       EnableSigning: true
       BUILDNUMBER: $(BUILDNUMBER)
-      KEYVAULT: $(KEYVAULT)
-      AZURESUBSCRIPTION: $(AZURESUBSCRIPTION)
 
 - stage: GenerateModules
   displayName: 'Generate Modules (Microsoft.Graph.*)'

.azure-pipelines/weekly-examples-update.yml

@@ -1,4 +1,5 @@
 # Copyright (c) Microsoft Corporation.  All Rights Reserved.  Licensed under the MIT License.  See License in the project root for license information.
+
 trigger: none # disable triggers based on commits.
 pr: none # disable as a PR gate.
 name: 'PowerShellExamplesUpdate Check'
@@ -57,4 +58,17 @@ jobs:
         git add .
         git commit -m "Updating examples "+$date
         git push --set-upstream "https://$(GITHUB_TOKEN)@github.com/microsoftgraph/msgraph-sdk-powershell.git" $proposedBranch
-        git status
+        git status
+
+  - task: PowerShell@2
+    displayName: Create examples update
+    env:
+      GITHUB_TOKEN: $(GITHUB_TOKEN)
+    inputs:
+      pwsh: true
+      targetType: inline
+      script: |
+        $Title = "[v1] Examples Update"
+        $Body = "This pull request was automatically created by Azure Pipelines. Contains examples update."
+        $BaseBranch = "dev"
+        . $(System.DefaultWorkingDirectory)/scripts/create-pull-request.ps1 -Title $Title -Body $Body -BaseBranchName $BaseBranch

.azure-pipelines/weekly-generation.yml

@@ -54,7 +54,9 @@ stages:
           AuthModulePath: "src/Authentication/Authentication"
           ServiceModulePath: "src/"
           ModulePrefix: "Microsoft.Graph"
+          BaseBranchName: $(BaseBranch)
           EnableSigning: false
           PublishToFeed: false
           GenerateCommandMetadata: true
           GenerateHelpDocs: true
+          GeneratePullRequest: true