Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should interface AuthProviderCallback accept null on accessToken? #115

Closed
sibelius opened this issue Sep 12, 2018 · 2 comments
Closed

should interface AuthProviderCallback accept null on accessToken? #115

sibelius opened this issue Sep 12, 2018 · 2 comments
Labels

Comments

@sibelius
Copy link

export interface AuthProviderCallback {
(error: any, accessToken: string): void
}

it makes sense when we got an error to get an access token

@muthurathinam
Copy link
Contributor

muthurathinam commented Sep 14, 2018

@sibelius Yeah this does make sense, and thanks for bringing this to light.
Will make the change. If you have done it first, submit a pull request. Am happy to review !

883186

@muthurathinam
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants