Skip to content

Commit d261c77

Browse files
Revert "Adding initial thoughts on Kiota JS for Graph"
This reverts commit 774d226.
1 parent 774d226 commit d261c77

File tree

8 files changed

+49
-174
lines changed

8 files changed

+49
-174
lines changed

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,13 @@
11
---
2+
name: Bug report
3+
about: Create a report to help us improve
4+
title: ''
5+
labels: ''
6+
assignees: ''
27

3-
name: Bug report about: Create a report to help us improve title: "" labels: "" assignees: "" ---# Bug Report
8+
---
9+
10+
# Bug Report
411

512
## Prerequisites
613

@@ -34,7 +41,6 @@ For more information, see the `CONTRIBUTING` guide.
3441
Add any other context about the problem here..
3542

3643
## Usage Information
37-
3844
Request ID - Value of the `requestId` field if you are receiving a Graph API error response
3945

4046
SDK Version - [SDK version you are using]

.github/ISSUE_TEMPLATE/feature_request.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,13 @@
11
---
2+
name: Feature request
3+
about: Suggest an idea for this project
4+
title: ''
5+
labels: ''
6+
assignees: ''
27

3-
name: Feature request about: Suggest an idea for this project title: "" labels: "" assignees: "" ---# Feature Request
8+
---
9+
10+
# Feature Request
411

512
## Is your feature request related to a problem? Please describe
613

changelogs/v3-upgrade-guide.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,8 @@
5454
## Enhancements
5555

5656
### Introducing support for `@azure/msal-browser`
57-
58-
- The 3.0.0 version introduces `AuthCodeMSALBrowserAuthenticationProvider` which supports authentication using the [MSAL Browser](https://www.npmjs.com/package/@azure/msal-browser)
59-
- `AuthCodeMSALBrowserAuthenticationProvider` enables authorization using the Authentication Code Flow with PKCE. Learn more about the [AuthCodeMSALBrowserAuthenticationProvider](https://github.com/microsoftgraph/msgraph-sdk-javascript/blob/dev/docs/AuthCodeMSALBrowserAuthenticationProvider.md).
57+
- The 3.0.0 version introduces `AuthCodeMSALBrowserAuthenticationProvider` which supports authentication using the [MSAL Browser](https://www.npmjs.com/package/@azure/msal-browser)
58+
- `AuthCodeMSALBrowserAuthenticationProvider` enables authorization using the Authentication Code Flow with PKCE. Learn more about the [AuthCodeMSALBrowserAuthenticationProvider](https://github.com/microsoftgraph/msgraph-sdk-javascript/blob/dev/docs/AuthCodeMSALBrowserAuthenticationProvider.md).
6059

6160
### Introducing support for `@azure/identity TokenCredentials`
6261

design/kiota-e2e.md

Lines changed: 0 additions & 147 deletions
This file was deleted.

design/large-file-upload-task-design.md

Lines changed: 18 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ This document proposes high-level design modifications to the `LargeFileUploadTa
44

55
- Enhancement - Support Node.js Stream upload. Issue [#320](https://github.com/microsoftgraph/msgraph-sdk-javascript/issues/320).
66
- Bug Fix - Support large file uploads to Outlook API. Issue [#359](https://github.com/microsoftgraph/msgraph-sdk-javascript/issues/359).
7-
- Enhancement- Support upload progress handler callback. Issue [#305](https://github.com/microsoftgraph/msgraph-sdk-javascript/issues/305).
7+
- Enhancement- Support upload progress handler callback. Issue [#305](https://github.com/microsoftgraph/msgraph-sdk-javascript/issues/305).
88

99
Outline of the current implementation -
1010

@@ -75,10 +75,21 @@ sliceFile(range: Range): ArrayBuffer | Blob {
7575
- The LargeFileUploadTask should allow uploads to OneDrive API, Outlook API and PrintDocument API.
7676
- Proposed changes-
7777
- Add class `UploadResult` containing `location` and `responseBody` properties.
78-
- `location` provides access to the `location` field in the response headers.
79-
- `responseBody` provides access to the Graph API response body.
80-
- The `upload` task should return the `UploadResult` object on successful completion of task.
81-
78+
- `location` provides access to the `location` field in the response headers.
79+
- `responseBody` provides access to the Graph API response body.
80+
- The `upload` task should return the `UploadResult` object on successful completion of task.
81+
8282
###### 3. Support upload progress handler callback
83-
84-
- Proposed changes - - Add interface -> `interface UploadEventHandler{ extraCallbackParam?: unknown; progress(range: Range, extraCallbackParam?: unknown):void }` - Add uploadEventHandlers option to -> `interface LargeFileUploadTaskOptions { rangeSize?: number; uploadEventHandlers?: UploadEventHandler; }` - In the `upload` function call the `uploadEventHandlers.progress()` function if defined.
83+
- Proposed changes -
84+
- Add interface -> `interface UploadEventHandler{
85+
extraCallbackParam?: unknown;
86+
progress(range: Range, extraCallbackParam?: unknown):void
87+
}`
88+
- Add uploadEventHandlers option to ->
89+
```
90+
interface LargeFileUploadTaskOptions {
91+
rangeSize?: number;
92+
uploadEventHandlers?: UploadEventHandler;
93+
}
94+
```
95+
- In the `upload` function call the `uploadEventHandlers.progress()` function if defined.

design/publishing.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
##### Current set up -
2222

23-
1. TypeScript Source Code
23+
1. TypeScript Source Code
2424
/ \
2525
Transpiles into JavaScript
2626
'lib' folder

docs/CancellingAHTTPRequest.md

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,21 @@
11
# Cancel a HTTP request
22

3-
> The `abort()` method of the AbortController interface aborts a DOM request (e.g. a Fetch request)
4-
>
3+
> The `abort()` method of the AbortController interface aborts a DOM request (e.g. a Fetch request)
4+
>
55
> -- [AbortController interface](https://developer.mozilla.org/en-US/docs/Web/API/AbortController)
66
7-
References -
8-
9-
- [AbortController interface](https://developer.mozilla.org/en-US/docs/Web/API/AbortController)
10-
- [abortcontroller npm](https://www.npmjs.com/package/abort-controller)
11-
- [abortcontroller-polyfill](https://www.npmjs.com/package/abortcontroller-polyfill)
12-
- [Example of the AbortController implementation](https://github.com/node-fetch/node-fetch#request-cancellation-with-abortsignal)
7+
References -
8+
* [AbortController interface](https://developer.mozilla.org/en-US/docs/Web/API/AbortController)
9+
* [abortcontroller npm](https://www.npmjs.com/package/abort-controller)
10+
* [abortcontroller-polyfill](https://www.npmjs.com/package/abortcontroller-polyfill)
11+
* [Example of the AbortController implementation](https://github.com/node-fetch/node-fetch#request-cancellation-with-abortsignal)
1312

1413
#### Following is how canceling a fetch call works:
1514

16-
- Create an AbortController instance.
17-
- That instance has a signal property.
18-
- Pass the signal as a fetch option for signal.
19-
- Call the AbortController's abort property to cancel all fetches that use that signal.
15+
* Create an AbortController instance.
16+
* That instance has a signal property.
17+
* Pass the signal as a fetch option for signal.
18+
* Call the AbortController's abort property to cancel all fetches that use that signal.
2019

2120
#### Setting the AbortController.signal as a fetch option while creating the MSGraph SDK Client instance:
2221

samples/javascript/clientInitialization/tokenCredentialAuthenticationProvider/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
4. Navigate to the samples folder [./samples]and run `npm install`
2020

21-
5. Navigate to secrets.js[./secrets] and populate all the values (tenantId, clientId, clientSecret, scopes)
21+
5. Navigate to secrets.js[./secrets] and populate all the values (tenantId, clientId, clientSecret, scopes)
2222

2323
6. Navigate to tokenCredentialAuthenticationProvider[./samples/javascript/clientInitialization/tokenCredentialAuthenticationProvider] in the samples directory.
2424

0 commit comments

Comments
 (0)