-
Notifications
You must be signed in to change notification settings - Fork 30
feature/batches execution #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- switches to json objects to avoid too much string manipulations - fixes a bug where the service root would be appended twice - adds missing unit tests
96fa18d
to
73219ae
Compare
src/test/java/com/microsoft/graph/content/MSBatchRequestContentTest.java
Show resolved
Hide resolved
Just as a note, if you're redoing how this batch request works, I would find it much more useful if it didn't reference okhttp Requests, as I've already hooked up our own IConnection and IHttpProvider, and don't really want to use okhttp. What would be ideal from my perspective would be a
Then IMessageRequest could expose Sorry if this feedback comes too late, or isn't too useful here. |
- makes internal method private
@tbelaire I think this is very valuable feedback that is unlocked by the fact that all the base requests used to be in the service library and now are in this core library. I don't want to block the v3 release on that and I want to involve the program managers in that potential redesign. I agree with the fact that the current implementation is overly complex and reimplements things we should get from the httpprovider and other layers. Do you mind opening a new issue providing all the details you already provided please? |
src/main/java/com/microsoft/graph/content/MSBatchResponseContent.java
Outdated
Show resolved
Hide resolved
…ests - enables and fixes last disabled tests for CoreHttpProvider
This PR not only improves code coverage and reliability of the whole batching implementation, but also makes usage simpler.
https://github.com/microsoftgraph/microsoft-graph-docs/compare/feature/java-sdk-v3?expand=1