Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature]: Validate all AppsAndFeaturesEntries fields #118948

Open
Trenly opened this issue Sep 5, 2023 · 0 comments
Open

[New Feature]: Validate all AppsAndFeaturesEntries fields #118948

Trenly opened this issue Sep 5, 2023 · 0 comments
Labels
Area-Validation-Pipeline Issues related to the manifest validation pipeline. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.

Comments

@Trenly
Copy link
Contributor

Trenly commented Sep 5, 2023

Description of the new feature/enhancement

There is currently the label Manifest-AppsAndFeaturesVersion-Error which is applied when the version in AppsAndFeaturesEntries doesn't match the version that is written as the DisplayVersion. However, this doesn't seem to catch some other errors in AppsAndFeaturesEntries.

For example, in this PR, it didn't detect that the ProductCode was not valid for any of the ARP entries -

When AppsAndFeaturesEntries are specified in the manifest, the validation pipeline should check for an exact match of the complete entry, not just specific fields.

Proposed technical implementation details (optional)

When an AppsAndFeaturesEntries item is present in the manifest, validate that there is an exact match for the entire object. If a field is not specified in the manifest, allow any value. Note that each entry should be compared on all fields for an exact match, since some programs may create multiple entries which may match each individual field collectively

@Trenly Trenly added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Sep 5, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage This work item needs to be triaged by a member of the core team. Area-Validation-Pipeline Issues related to the manifest validation pipeline. labels Sep 5, 2023
@stephengillie stephengillie removed the Needs-Triage This work item needs to be triaged by a member of the core team. label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Validation-Pipeline Issues related to the manifest validation pipeline. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Projects
None yet
Development

No branches or pull requests

2 participants